Auto-fixes stopped working on 0.28.0 release (when having conditional expressions)

[bkaid]

I upgraded from 0.27.0 to 0.28.0 and ran dotnet format to apply the auto-fixes like I generally do for each of the last few releases on a code base that has a mix of xunit syntax and fluent assertions syntax. With this release I am getting an unexpected error and no files get changed even though the logs say they do. I have attached the full diagnostic log from running dotnet format -v diag >> log.txt which doesn't seem to contain much information. The console output when running the same command contains:

dotnet format -v diag >> log.txt
Unable to fix FAA0002. Code fix XunitCodeFixProvider didn't return a Fix All action.
Unable to fix FAA0002. Code fix XunitCodeFixProvider didn't return a Fix All action.
Failed to get new expression in FluentAssertions.Analyzers.FluentAssertionsCodeFix.
System.InvalidOperationException: should not get here
   at FluentAssertions.Analyzers.FluentAssertionsCodeFixProvider.GetNewExpression(ExpressionSyntax expression, NodeReplacement replacement)
   at FluentAssertions.Analyzers.FluentAssertionsCodeFixProvider.GetNewExpression(ExpressionSyntax expression, NodeReplacement[] replacements)
   at FluentAssertions.Analyzers.FluentAssertionsCodeFix.GetNewExpression(ExpressionSyntax expression, FluentAssertionsDiagnosticProperties properties)
   at FluentAssertions.Analyzers.FluentAssertionsCodeFixProvider.GetNewExpressionAsync(ExpressionSyntax expression, Document document, FluentAssertionsDiagnosticProperties properties, CancellationToken cancellationToken)
   at FluentAssertions.Analyzers.FluentAssertionsCodeFixProvider.GetNewExpressionSafelyAsync(ExpressionSyntax expression, Document document, FluentAssertionsDiagnosticProperties properties, CancellationToken cancellationToken)
Unable to fix FAA0001. Code fix FluentAssertionsCodeFix didn't return a Fix All action.
Failed to get new expression in FluentAssertions.Analyzers.FluentAssertionsCodeFix.
System.InvalidOperationException: should not get here
   at FluentAssertions.Analyzers.FluentAssertionsCodeFixProvider.GetNewExpression(ExpressionSyntax expression, NodeReplacement replacement)
   at FluentAssertions.Analyzers.FluentAssertionsCodeFixProvider.GetNewExpression(ExpressionSyntax expression, NodeReplacement[] replacements)
   at FluentAssertions.Analyzers.FluentAssertionsCodeFix.GetNewExpression(ExpressionSyntax expression, FluentAssertionsDiagnosticProperties properties)
   at FluentAssertions.Analyzers.FluentAssertionsCodeFixProvider.GetNewExpressionAsync(ExpressionSyntax expression, Document document, FluentAssertionsDiagnosticProperties properties, CancellationToken cancellationToken)
   at FluentAssertions.Analyzers.FluentAssertionsCodeFixProvider.GetNewExpressionSafelyAsync(ExpressionSyntax expression, Document document, FluentAssertionsDiagnosticProperties properties, CancellationToken cancellationToken)
Unable to fix FAA0001. Code fix FluentAssertionsCodeFix didn't return a Fix All action.

log.txt

[Meir017]

@bkaid are you able to a minimal code snippet to reproduce this?
does executing a single fix in your IDE work?
is the issue happening only when running dotnet format?

[bkaid]

By process of elimination, by manually making this single code change:

- response.MyCollection?.Count().Should().Be(2);
+ response.MyCollection?.Should().HaveCount(2);

The dotnet format result no longer throws should not get here errors:

dotnet format
Unable to fix FAA0002. Code fix XunitCodeFixProvider didn't return a Fix All action.
Unable to fix FAA0002. Code fix XunitCodeFixProvider didn't return a Fix All action.

Response looks like:

    public class MyResponse
    {
        public IEnumerable<MyCollectionType>? MyCollection { get; set; }
    }

[Meir017]

@bkaid I'm able to reproduce this, with the new improved analyzers the scenario of having a ConditionalAccessExpression is also detected by the fluent-assertions analyzers, not only by the NullConditionalAssertion (FluentAssertions0800).

for the specific scenario you have version 0.27.0 would suggest any fix

[Meir017]

@bkaid please try the new version 0.29.0

[bkaid]

Works again, thank you!