Fix NullConditionalAssertion false positive #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on creates false negatives.
…sExpressionSyntax already includes this.
|
Is there a reason this hasn't been merged yet? Is there anything I can help with? |
Meir017
approved these changes
May 23, 2023
|
@renzo-baasdam @rcdailey version 0.17.3 is out now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #91, the NullConditionalAssertion analyzer gives a false positive for statements like:
(actual?.MyProperty).Should().Be(expected);This PR should fix the above case along with statements where a null-conditional is used in an argument list, for example:
actual.MyList.Where(obj => obj?.ToString() == null).Count().Should().Be(expected);