fix: #1447 Dropdown Hint missing#1493
Merged
deandreamatias merged 1 commit intoflutter-form-builder-ecosystem:mainfrom Jun 9, 2025
Merged
fix: #1447 Dropdown Hint missing#1493deandreamatias merged 1 commit intoflutter-form-builder-ecosystem:mainfrom
deandreamatias merged 1 commit intoflutter-form-builder-ecosystem:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1493 +/- ##
=======================================
Coverage 89.88% 89.88%
=======================================
Files 21 21
Lines 840 840
=======================================
Hits 755 755
Misses 85 85 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I just realized after the fact that there is a |
84dbb3f
into
flutter-form-builder-ecosystem:main
9 of 11 checks passed
|
@mvarendorff2 yes the hint label doesn't appear in the dropdown how to fix it ? |
deandreamatias
added a commit
that referenced
this pull request
Jul 6, 2025
fix: #1447 Dropdown Hint missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
Close #1447
Solution description
The hint is only shown on an InputDecorator based on several states. One thing that has to be set for the hint to show is
isEmpty: true, however this was not passed to the decorator from the dropdown field, thus always hiding the hint and label, regardless of contents.Screenshots or Videos
Repro-Widget (boilerplate omitted for brevity):
On 10.0.1 this will not render
Hint is here. With this PR it will.To Do