This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add missing raster cache LRU accounting to Get()#16431
Closed
cbracken wants to merge 1 commit into
Closed
Conversation
RasterCache::Get() methods were not updating the RasterCache::Entry access_count and used_this_frame fields, as is done in RasterCache::Prepare(). This can result in onscreen images being evicted from the cache as new entries are created (e.g. as new elements scroll onscreen).
Contributor
Author
chinmaygarde
approved these changes
Feb 6, 2020
chinmaygarde
left a comment
chinmaygarde
left a comment
Contributor
There was a problem hiding this comment.
I expect this is high priority for the linked b/ issue. But can we add a flow_unittests test case for this please? If urgent, feel free to land and I'll add a test.
| if (it == picture_cache_.end()) { | ||
| return RasterCacheResult(); | ||
| } | ||
| Entry& entry = const_cast<Entry&>(it->second); |
Contributor
There was a problem hiding this comment.
Can we dry this up just a little bit by creating a method that takes a key and returns a cache result whose entry has its access counted bumped already?
Contributor
Author
|
Fixes flutter/flutter#50226 |
Contributor
Author
|
Closed in favour of #16434. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RasterCache::Get() methods were not updating the RasterCache::Entry
access_count and used_this_frame fields, as is done in
RasterCache::Prepare(). This can result in onscreen images being evicted
from the cache as new entries are created (e.g. as new elements scroll
onscreen).