Reverts "[Impeller] support GLES 3.0 MSAA without extension. (#56705)"#56741
Conversation
This reverts commit ec065be.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
flutter-team-archive/engine@d1a0806...6f941c9 2024-11-21 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] support GLES 3.0 MSAA without extension. (#56705)" (flutter-team-archive/engine#56741) 2024-11-21 skia-flutter-autoroll@skia.org Roll Dart SDK from dde57dc75c15 to b36e4d731d67 (1 revision) (flutter-team-archive/engine#56723) 2024-11-21 dacoharkes@google.com [native assets] Consume `NativeAssetsManifest.json` (flutter-team-archive/engine#56727) 2024-11-21 jonahwilliams@google.com [Impeller] support GLES 3.0 MSAA without extension. (flutter-team-archive/engine#56705) 2024-11-21 30870216+gaaclarke@users.noreply.github.com Updated some impeller benchmark urls (flutter-team-archive/engine#56721) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…#56705)" (flutter-team-archive/engine#56741) Reverts: flutter-team-archive/engine#56705 Initiated by: jonahwilliams Reason for reverting: goldens occassionally fail to render anything. Original PR Author: jonahwilliams Reviewed By: {gaaclarke} This change reverts the following previous change: Adds multisampling support for GLES devices without GL_EXT_multisampled_render_to_texture provided they are at least GLES 3.0 to support mutlisampled render buffers. Fixes flutter#158360 Fixes flutter#157951 TBD: should we prefer renderbuffer 3.0 approach over multisample_render_to_texture?
Reverts: #56705
Initiated by: jonahwilliams
Reason for reverting: goldens occassionally fail to render anything.
Original PR Author: jonahwilliams
Reviewed By: {gaaclarke}
This change reverts the following previous change:
Adds multisampling support for GLES devices without GL_EXT_multisampled_render_to_texture provided they are at least GLES 3.0 to support mutlisampled render buffers.
Fixes flutter/flutter#158360
Fixes flutter/flutter#157951
TBD: should we prefer renderbuffer 3.0 approach over multisample_render_to_texture?