Skip to content

Add support for incoming application control #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 10, 2021

Conversation

rwalczyna
Copy link
Contributor

@rwalczyna rwalczyna commented Jul 23, 2021

This change is needed to provide support for OnAppControlReceived callback.
As there is no way to pass object from embedder to plugins without changing plugins API, I have decided to create internal App Control Channel inside engine. I am open for discussion if there is any easier solution for this case.

Corresponding engine change: flutter-tizen/engine#154

Dart part of the plugin is currently in internal f-project repository.

I wanted to use most recent code of embedder and engine and I had to put this PR after #171, so #171 should land first.

@WonyoungChoi
Copy link
Contributor

@rwalczyna please rebase this PR first.

pkosko added 2 commits July 27, 2021 12:27
* support in C# service application
* changed IntPtr to SafeAppControlHandle
@bbrto21
Copy link
Contributor

bbrto21 commented Jul 28, 2021

@rwalczyna
Question : after all of the things related to this, will we have a structure similar to supporting intent in Android?
https://flutter.dev/docs/get-started/flutter-for/android-devs#how-do-i-handle-incoming-intents-from-external-applications-in-flutter

@swift-kim
Copy link
Member

I published a new engine release which includes the change flutter-tizen/engine#154.

Please update the engine hash (bin/internal/engine.version) to 7ffeb878c5d4d703968defe9fcbe2fed294c1a81.

@pkosko
Copy link
Contributor

pkosko commented Aug 9, 2021

@rwalczyna
Question : after all of the things related to this, will we have a structure similar to supporting intent in Android?
https://flutter.dev/docs/get-started/flutter-for/android-devs#how-do-i-handle-incoming-intents-from-external-applications-in-flutter

It is an implementation for https://docs.tizen.org/application/web/guides/app-management/app-controls/, but I believe that it is a similar mechanism as in quoted link.

Copy link
Member

@swift-kim swift-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@swift-kim swift-kim merged commit 2fa6cab into flutter-tizen:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants