Bump minimum android_api_level to 19 #750
Conversation
We don't support API levels 18 and below anyway.
|
cc @reidbaker for another review. We believe this is good to go but not sure if there was some other hold. |
|
Please hold on this PR. We have a single google customer that we are waiting on to update their minSdk. ETA is mid next week. I am surprised that FROB didnt fail on this pr. cl/551217709 |
|
@reidbaker FROB does not fail because these two things are unconnected. AndroidManifest can say minSdk=16 while engine C++ is compiled assuming something newer. For example ARM64 and X64 builds of engine are building with SDK version set to 22 already. See default value for |
Thanks for this explanation |
|
@reidbaker thanks for approving! is buildroot autorolled into engine or should I roll manually? |
|
I actually dont know @chinmaygarde can you answer? |
|
I checked autoroller configurations and I could not find one for buildroot - so I am going to roll manually. |
|
No. There is no buildroot autoroller. |
The latest Robolectric version, 4.11.x, removed the support for SDKs < 19 by following AndroidX strategy. Also following flutter/buildroot#750, and removing obsolete SDK checking in code to pass android_lint checking after bumping minSdk to 19 for testing target. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Reverts #47686 Initiated by: zanderso This change reverts the following previous change: Original Description: The latest Robolectric version, 4.11.x, removed the support for SDKs < 19 by following AndroidX strategy. Also following flutter/buildroot#750, and removing obsolete SDK checking in code to pass android_lint checking after bumping minSdk to 19 for testing target. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
We don't support API levels 18 and below anyway.
I would like to make a change to Dart SDK that requires API level 18 or above.