Skip to content

Rename NavigationDrawer to DashboardNavigationDrawer because NavigationDrawer will be a material widget #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2022
Merged

Rename NavigationDrawer to DashboardNavigationDrawer because NavigationDrawer will be a material widget #2313

merged 1 commit into from
Nov 18, 2022

Conversation

hannah-hyj
Copy link
Member

@hannah-hyj hannah-hyj commented Nov 18, 2022 •
edited
Loading

issue:flutter/flutter#115476

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • [] I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

HansMuller
HansMuller approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App. label Nov 18, 2022
@auto-submit auto-submit bot merged commit 31fd6af into flutter:main Nov 18, 2022
@XilaiZhang XilaiZhang mentioned this pull request Feb 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

@jmagman jmagman Awaiting requested review from jmagman

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannah-hyj @HansMuller