Skip to content

Add the mimetype for smcbin file extension #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2023

Conversation

ricardoamador
Copy link
Contributor

@ricardoamador ricardoamador commented May 18, 2023

Changes were made to switch the file extension for AssetManifest.bin to smcbin which is not a normal file extension and therefore has no associated mimetype. This change can be found here: flutter/flutter#126077

Without this change the dashboard fails to display all icons in the top column above the builds.
image

With the added mimetype the icons are present.
image

List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#127038

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ricardoamador ricardoamador added the autosubmit Merge PR when tree becomes green via auto submit App. label May 18, 2023
@auto-submit auto-submit bot merged commit 2bfdbe9 into flutter:main May 18, 2023
@ricardoamador ricardoamador deleted the cocoon_fix_mimetype_smcbin branch July 5, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants