fix: codelab example step01 Platform.is* call (#36126) #1053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrienLemaire
commented
Aug 3, 2022
| @@ -13,7 +12,9 @@ Future setDesktopWindow() async { | |||
| void main() { | |||
| WidgetsFlutterBinding.ensureInitialized(); | |||
|
|
|||
| if (Platform.isWindows || Platform.isLinux || Platform.isMacOS) { | |||
| if (UniversalPlatform.isWindows || | |||
There was a problem hiding this comment.
Fixed following this comment
|
Thanks @AdrienLemaire! I've gone ahead and added those changes to all of the step projects. |
khanhnwin
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
The codelab boring-to-beautiful fails with error
Unsupported operation: Platform._operatingSystemList which issues are fixed by this PR. For larger changes, raising an issue first helps
reduce redundant work.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.