Stop calling getButton() in ComponentWithBrowseButton

[jwren]

This API is marked to be removed from the API in the platform, see https://github.com/JetBrains/intellij-community/blob/master/platform/platform-api/src/com/intellij/openapi/ui/ComponentWithBrowseButton.java#L270

This changes the output from the verifier from 4 usages of scheduled for removal API to 2 usages of scheduled for removal API

[pq]

Cool! Have you confirmed that this works? Previously we were listening to the button and now the listener is attached to the text field. It seems like this will be triggered for text entry or clicks (which I don't think we want) but not for clicks on the browse button (which we do).

[jwren]

Cool! Have you confirmed that this works? Previously we were listening to the button and now the listener is attached to the text field. It seems like this will be triggered for text entry or clicks (which I don't think we want) but not for clicks on the browse button (which we do).

Yes, I validated that it works as intended.

[pq]

Cool. Thanks!

Looking closer, the API is odd and as it happens addActionListener just delegates to the button:

https://github.com/JetBrains/intellij-community/blob/0316cc7e494d2d7497daebf15402883d705b1144/platform/platform-api/src/com/intellij/openapi/ui/ComponentWithBrowseButton.java#L192-L194

(Not sure why they didn't stick to addBrowseListener which seems more legible to me! 🤷 )