[build] de-noise output: defer DART_HOME check until test execution#304
Draft
pq wants to merge 2 commits intoflutter:mainfrom
Draft
[build] de-noise output: defer DART_HOME check until test execution#304pq wants to merge 2 commits intoflutter:mainfrom
DART_HOME check until test execution#304pq wants to merge 2 commits intoflutter:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the test task configuration in third_party/build.gradle.kts by wrapping the Dart SDK path validation and JVM argument setup within a doFirst block to ensure it only runs during task execution. A review comment points out that modifying task configuration inside doFirst is discouraged in modern Gradle because it interferes with the Configuration Cache and task up-to-date checks. The reviewer suggests using the providers API to lazily set the system property while keeping only the validation logging inside doFirst.
Collaborator
Author
|
WIP apparently! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DART_HOMEcheck was happening eagerly during the configuration step which a spam warning when building the plugin. This fixes that.Warning for Tests
Not for Buiilds
Contribution guidelines:
dart format.