Skip to content

P1: Support diffing snapshots in the memory view #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kenzieschmoll opened this issue Dec 7, 2020 · 1 comment
Closed

P1: Support diffing snapshots in the memory view #2535

kenzieschmoll opened this issue Dec 7, 2020 · 1 comment
Assignees
@terrylucas
Labels
screen: memory Issues with the Memory screen.
Milestone
M41

Comments

@kenzieschmoll
Copy link
Member

From @terrylucas

Diffing will first be a manual operation in DevTools then the VM will expose this functionality. The manual diffing can't match the objects between snapshots to track real changes. We will have to compare total objects, total size (maybe allocation tracking @ snapshot time to see if objects allocated increased of decreased) to come up with a quasi diffing . If we find dff'ing to be helpful then the VM will add for a faster and more accurate information.
@kenzieschmoll kenzieschmoll added the screen: memory Issues with the Memory screen. label Dec 7, 2020
@kenzieschmoll kenzieschmoll changed the title Support diffing snapshots in the memory view P1: Support diffing snapshots in the memory view Dec 7, 2020
@kenzieschmoll kenzieschmoll changed the title P1: Support diffing snapshots in the memory view P2: Support diffing snapshots in the memory view Feb 9, 2021
@kenzieschmoll kenzieschmoll added this to the M29 milestone May 5, 2021
@kenzieschmoll kenzieschmoll modified the milestones: M29, M30 Jun 2, 2021
@kenzieschmoll kenzieschmoll modified the milestones: M30, M31 Jun 30, 2021
@kenzieschmoll kenzieschmoll modified the milestones: M31, M32 Aug 4, 2021
@kenzieschmoll kenzieschmoll modified the milestones: M32, M33 Aug 26, 2021
@kenzieschmoll kenzieschmoll modified the milestones: M33, M34 Oct 7, 2021
@kenzieschmoll kenzieschmoll modified the milestones: M34, M35 Oct 21, 2021
@kenzieschmoll kenzieschmoll changed the title P2: Support diffing snapshots in the memory view P1: Support diffing snapshots in the memory view Jan 26, 2022
@kenzieschmoll kenzieschmoll modified the milestones: M35, M39 Feb 15, 2022
@kenzieschmoll kenzieschmoll modified the milestones: M39, M41 May 5, 2022
@kenzieschmoll kenzieschmoll mentioned this issue May 5, 2022
Closed
@kenzieschmoll
Copy link
Member Author

closing as dupe of #3949 - there is additional context there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrylucas terrylucas

Labels
screen: memory Issues with the Memory screen.
Projects
None yet
Milestone
M41
Development

No branches or pull requests
2 participants
@terrylucas @kenzieschmoll