Skip to content

Memory screen: implement profile diff. #3949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
17 tasks done
polina-c opened this issue Apr 1, 2022 · 2 comments
Closed
17 tasks done

Memory screen: implement profile diff. #3949

polina-c opened this issue Apr 1, 2022 · 2 comments
Assignees
@terrylucas @polina-c
Labels
screen: memory Issues with the Memory screen.
Milestone
M41

Comments

@polina-c
Copy link
Contributor

polina-c commented Apr 1, 2022 •
edited
Loading

go/devtools-memory-page-vision

Build:

  • crud for snapshots
  • fakes for memory page
  • show snapshot stats
  • show diff stats
  • show diff details
  • export to CSV
  • filter by class / library
  • Move button 'Clear'
  • Preserve sorting between data sets of classes and pathes

Clean up:

After MVP clean up:
@polina-c polina-c added the screen: memory Issues with the Memory screen. label Apr 1, 2022
@polina-c polina-c added this to the M39 milestone Apr 1, 2022
@polina-c polina-c self-assigned this Apr 1, 2022
@polina-c
Copy link
Contributor Author

polina-c commented Apr 5, 2022 •
edited
Loading

Diff snapshot in Chrome devtools:

Screen Shot 2022-04-05 at 3 30 50 PM

See https://www.youtube.com/watch?v=63Os4MbobNM

@polina-c polina-c changed the title Memory screen: implement diff snapshot functionality. Memory screen: implement diff snapshot. Apr 5, 2022
@polina-c polina-c changed the title Memory screen: implement diff snapshot. Memory screen: implement snapshot diff. Apr 5, 2022
@terrylucas
Copy link
Contributor

Got it.

This was referenced May 5, 2022
Closed
Closed
@kenzieschmoll kenzieschmoll modified the milestones: M39, M41 May 5, 2022
@polina-c polina-c added the P4 label May 20, 2022
@polina-c polina-c added P3 and removed P4 labels Jun 15, 2022
@polina-c polina-c changed the title Memory screen: implement snapshot diff. Memory screen: implement profile diff. Jun 15, 2022
This was referenced Sep 20, 2022
Closed
Merged
Merged
@polina-c polina-c mentioned this issue Oct 8, 2022
Closed
2 tasks
@polina-c polina-c mentioned this issue Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrylucas terrylucas

@polina-c polina-c

Labels
screen: memory Issues with the Memory screen.
Projects
None yet
Milestone
M41
Development

No branches or pull requests
3 participants
@terrylucas @polina-c @kenzieschmoll