Add appSizeBase and appSizeTest args to the devtools server
#2546
Conversation
| // not be specified (it should only be present for diffs). If [appSizeTest] | ||
| // is present without [appSizeBase], we will ignore the parameter. | ||
| if (appSizeBase != null) { | ||
| final startQueryParamIndex = url.indexOf('?'); |
There was a problem hiding this comment.
use uri parsing instead of indexof
There was a problem hiding this comment.
when I tried to add /#/appsize using Uri.replace(path: '/#/appsize), the # is encoded and the url does load properly.
There was a problem hiding this comment.
I think you want to use fragment to change the fragment property rather than path.
https://api.dart.dev/stable/2.10.4/dart-core/Uri/fragment.html
There was a problem hiding this comment.
this also doesn't work because the fragment is after the query parameters (http://127.0.0.1:9102?appSizeBase=old.json&appSizeTest=new.json#appsize), and devtools expects the fragment id to be before the query parameters (http://127.0.0.1:9102/#/appsize?appSizeBase=old.json&appSizeTest=new.json)
There was a problem hiding this comment.
where in devtools are we requiring the fragment to be before the query parameters? that seems like a bug.
There was a problem hiding this comment.
see #2475 for some input from danny
This will allow specifying
appSizeBaseandappSizeTestfile paths as args to the server (e.g.--appSizeBase old.json --appSizeTest new.json)