Add a key set command for opening a file #3315
Conversation
| HostPlatform.instance.isMacOS | ||
| ? LogicalKeyboardKey.meta | ||
| : LogicalKeyboardKey.control, | ||
| LogicalKeyboardKey.keyP, |
There was a problem hiding this comment.
this is the same as focusLibraryFilterKeySet above. Maybe use 'o' for this one for now? At least until @bkonyi's changes land and we have ripped out the filter in the libraries window. Then we can decide whether we want to have this hot key be cmd + p or cmd + o long term. I expect both the open file feature and Ben's changes will be done for the Oct release.
There was a problem hiding this comment.
Oh good catch! Switched to cmd + o
There was a problem hiding this comment.
CTRL-P is definitely preferable since most editors use that as a shortcut for file searching. Will it help if I upload a small PR to remove the filter box? It shouldn't be very difficult to do.
There was a problem hiding this comment.
Sure, if that's not too much trouble that would be great! Thanks
There was a problem hiding this comment.
commented on Ben's PR, but will add a note here too - we shouldn't land #3319 until after the release goes out tomorrow. We don't want to remove the filtering functionality before we replace it with the open file dialog feature.
Adds
CTRL + P/CMD + Pas a key set, which will be used to open the file opener dialog.Also pulls the key sets definitions out into their own file within the debugger directory.