Show Performance and CPU Profiler screens without app connection #6567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
approved these changes
Oct 20, 2023
CoderDake
approved these changes
Oct 23, 2023
packages/devtools_app/lib/src/screens/performance/performance_screen.dart
Outdated
Show resolved
Hide resolved
…screen.dart Co-authored-by: Daniel Chevalier <[email protected]>
kenzieschmoll
force-pushed
the
open-offline
branch
from
fa5f96c to
423705c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the app connection, these screens are here to provide users with a way to load offline data. This PR also removes the ImportFileAction from the set of scaffold actions, and replaces the existing "Export" buttons with a new
OpenSaveButtonGroup, since we will keep these actions local to the screens that support Open / Save.Error message when importing a DevTools file for the incorrect screen:
New Open / Save actions:
Fixes #4645