Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 2bc9cc1

Browse files
mspangCommit Bot
authored and
Commit Bot
committed
Fuchsia: Blacklist swiftshader on Fuchsia
This doesn't work and is highly misleading as the tests run with the real GPU. Bug: angleproject:4353 Change-Id: Id9139436e39d5e8e063bcc679b7c63f589d3b748 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2023912 Commit-Queue: Michael Spang <[email protected]> Reviewed-by: Jamie Madill <[email protected]>
1 parent 44c7507 commit 2bc9cc1

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/tests/test_utils/angle_test_instantiate.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,11 @@ bool IsConfigWhitelisted(const SystemInfo &systemInfo, const PlatformParameters
373373
if (param.majorVersion > 2 && IsARM())
374374
return false;
375375

376+
// Loading swiftshader is not brought up on Fuchsia.
377+
// TODO(anglebug.com/4353): Support loading swiftshader vulkan ICD.
378+
if (param.getDeviceType() == EGL_PLATFORM_ANGLE_DEVICE_TYPE_SWIFTSHADER_ANGLE)
379+
return false;
380+
376381
// Currently we only support the Vulkan back-end on Fuchsia.
377382
return (param.getRenderer() == EGL_PLATFORM_ANGLE_TYPE_VULKAN_ANGLE);
378383
}

0 commit comments

Comments
 (0)