Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 462e9bb

Browse files
authored
[impeller] fixed flake where blit wasn't tracking its texture (#41347)
fixes flutter/flutter#125147 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
1 parent 4905d53 commit 462e9bb

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

impeller/renderer/backend/vulkan/blit_command_vk.cc

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,10 @@ bool BlitCopyTextureToTextureCommandVK::Encode(
2929
const auto& src = TextureVK::Cast(*source);
3030
const auto& dst = TextureVK::Cast(*destination);
3131

32+
if (!encoder.Track(source) || !encoder.Track(destination)) {
33+
return false;
34+
}
35+
3236
LayoutTransition src_tran;
3337
src_tran.cmd_buffer = cmd_buffer;
3438
src_tran.new_layout = vk::ImageLayout::eTransferSrcOptimal;
@@ -96,6 +100,10 @@ bool BlitCopyTextureToBufferCommandVK::Encode(CommandEncoderVK& encoder) const {
96100
// cast source and destination to TextureVK
97101
const auto& src = TextureVK::Cast(*source);
98102

103+
if (!encoder.Track(source)) {
104+
return false;
105+
}
106+
99107
LayoutTransition transition;
100108
transition.cmd_buffer = cmd_buffer;
101109
transition.new_layout = vk::ImageLayout::eTransferSrcOptimal;
@@ -190,6 +198,10 @@ bool BlitGenerateMipmapCommandVK::Encode(CommandEncoderVK& encoder) const {
190198
const auto& image = src.GetImage();
191199
const auto& cmd = encoder.GetCommandBuffer();
192200

201+
if (!encoder.Track(texture)) {
202+
return false;
203+
}
204+
193205
// Transition the base mip level to transfer-src layout so we can read from
194206
// it and transition the rest to dst-optimal since they are going to be
195207
// written to.

0 commit comments

Comments
 (0)