This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[impeller] fixed flake where blit wasn't tracking its texture #41347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chinmaygarde Let me know if you have any ideas on how to make this less likely to happen in the future. It seems like an easy mistake to make and it's difficult to debug. Nothing about the failure communicated to me that the command buffer was referencing a texture that doesn't exist. I mentioned in the chat but maybe we should make people requesting the command buffer to state their tracked resources at the same time so that they have to explicitly omit tracking a resource. That may help. |
|
By extension, shouldn't |
|
I expanded this to the other blit commands. Every 10th run of the unit tests can pass now, but there seems to be another case where we aren't tracking something we should be. |
|
@chinmaygarde can you please give this a review. This makes sense to me but I want to double check that it does for you too. After we decide that I can look into adding tests and we can think about how to maybe change the API to make this harder to happen or easier to debug. |
|
I'm going to put this up for review, it is technically covered by playground tests but I plan on investigating creating a more extensive testing platform that will allow us to assert this problem directly. |
chinmaygarde
approved these changes
Apr 21, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 21, 2023
…125324) flutter/engine@dd67063...462e9bb 2023-04-21 [email protected] [impeller] fixed flake where blit wasn't tracking its texture (flutter/engine#41347) 2023-04-21 [email protected] removing the check_gn_format.py file from ci/ (flutter/engine#41397) 2023-04-21 [email protected] [web] Fix HashUrlStrategy.addPopStateListener (flutter/engine#41384) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
ditman
pushed a commit
to ditman/flutter-flutter
that referenced
this pull request
Apr 24, 2023
…lutter#125324) flutter/engine@dd67063...462e9bb 2023-04-21 [email protected] [impeller] fixed flake where blit wasn't tracking its texture (flutter/engine#41347) 2023-04-21 [email protected] removing the check_gn_format.py file from ci/ (flutter/engine#41397) 2023-04-21 [email protected] [web] Fix HashUrlStrategy.addPopStateListener (flutter/engine#41384) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
gaaclarke
added a commit
that referenced
this pull request
Apr 25, 2023
…for tests (#41408) Adds test for #41347 and adds an extra fix for flutter/flutter#125147. Testing this is possible because I've mocked out all of vulkan. We can expand on this in the future we want to be more robust. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#125147
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.