Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 691cb95

Browse files
authored
Revert "[Impeller] Load instead of restore drawing for non-MSAA passes" (#41060)
Revert "[Impeller] Load instead of restore drawing for non-MSAA passes"
1 parent b2a896e commit 691cb95

File tree

2 files changed

+3
-11
lines changed

2 files changed

+3
-11
lines changed

impeller/entity/inline_pass_context.cc

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -100,10 +100,7 @@ InlinePassContext::RenderPassResult InlinePassContext::GetRenderPass(
100100

101101
RenderPassResult result;
102102

103-
if (pass_count_ > 0 && pass_target_.GetRenderTarget()
104-
.GetColorAttachments()
105-
.find(0)
106-
->second.resolve_texture) {
103+
if (pass_count_ > 0) {
107104
result.backdrop_texture =
108105
pass_target_.Flip(*context_->GetResourceAllocator());
109106
if (!result.backdrop_texture) {
@@ -114,12 +111,8 @@ InlinePassContext::RenderPassResult InlinePassContext::GetRenderPass(
114111
auto color0 =
115112
pass_target_.GetRenderTarget().GetColorAttachments().find(0)->second;
116113

117-
if (pass_count_ > 0) {
118-
color0.load_action =
119-
color0.resolve_texture ? LoadAction::kDontCare : LoadAction::kLoad;
120-
} else {
121-
color0.load_action = LoadAction::kClear;
122-
}
114+
color0.load_action =
115+
pass_count_ > 0 ? LoadAction::kDontCare : LoadAction::kClear;
123116

124117
color0.store_action = color0.resolve_texture
125118
? StoreAction::kMultisampleResolve

impeller/entity/inline_pass_context.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ class InlinePassContext {
1515
public:
1616
struct RenderPassResult {
1717
std::shared_ptr<RenderPass> pass;
18-
1918
std::shared_ptr<Texture> backdrop_texture;
2019
};
2120

0 commit comments

Comments
 (0)