Revert "[Impeller] Load instead of restore drawing for non-MSAA passes" #41060
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
…s" (flutter#41060) Revert "[Impeller] Load instead of restore drawing for non-MSAA passes"
This is essentially a revert of #41060 with better comments.
Reverts #40436
I believe #41052 fixes the actual problem that was occurring here when the Flip use is present. According to @jason-simmons, this change is actually breaking the Cupertino picker in gallery.
I'm not sure why this is broken in GLES yet. There should be no problem "loading" (doing nothing in GLES) to prepare continued writes to single sample textures when we begin the next pass.