Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit ece5915

Browse files
Reverts "[Impeller] disable blending in gaussian intermediate steps. (#51118)" (#51244)
Reverts: #51118 Initiated by: jonahwilliams Reason for reverting: unexpected performance change https://flutter-flutter-perf.skia.org/e/?queries=sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dbackdrop_filter_perf_ios__timeline_summary&selected=commit%3D39677%26name%3D%252Carch%253 Original PR Author: jonahwilliams Reviewed By: {gaaclarke} This change reverts the following previous change: Noticed this while working on the StC debugging. We can disable blending on all intermediate gaussian steps. I don't know how much of an impact this has in practice.
1 parent 4f6ea31 commit ece5915

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

impeller/entity/contents/filters/gaussian_blur_filter_contents.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@
1212
#include "impeller/entity/contents/content_context.h"
1313
#include "impeller/entity/texture_fill.frag.h"
1414
#include "impeller/entity/texture_fill.vert.h"
15+
#include "impeller/renderer/command.h"
1516
#include "impeller/renderer/render_pass.h"
17+
#include "impeller/renderer/texture_mipmap.h"
1618
#include "impeller/renderer/vertex_buffer_builder.h"
1719

1820
namespace impeller {
@@ -87,7 +89,6 @@ fml::StatusOr<RenderTarget> MakeDownsampleSubpass(
8789
pass.SetCommandLabel("Gaussian blur downsample");
8890
auto pipeline_options = OptionsFromPass(pass);
8991
pipeline_options.primitive_type = PrimitiveType::kTriangleStrip;
90-
pipeline_options.blend_mode = BlendMode::kSource;
9192
pass.SetPipeline(renderer.GetTexturePipeline(pipeline_options));
9293

9394
TextureFillVertexShader::FrameInfo frame_info;
@@ -149,7 +150,6 @@ fml::StatusOr<RenderTarget> MakeBlurSubpass(
149150

150151
ContentContextOptions options = OptionsFromPass(pass);
151152
options.primitive_type = PrimitiveType::kTriangleStrip;
152-
options.blend_mode = BlendMode::kSource;
153153

154154
if (tile_mode == Entity::TileMode::kDecal &&
155155
!renderer.GetDeviceCapabilities()

0 commit comments

Comments
 (0)