This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] disable blending in gaussian intermediate steps. #51118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Mar 5, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 6, 2024
…144659) flutter/engine@effcf97...d374c78 2024-03-06 [email protected] Revamp the `scenario_app/../README.md` to encourage self-sustenance (flutter/engine#51196) 2024-03-06 [email protected] [Impeller] disable blending in gaussian intermediate steps. (flutter/engine#51118) 2024-03-06 [email protected] [Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (flutter/engine#51219) 2024-03-06 [email protected] Roll Skia from 37947aec8c5c to 1d1fd7fe1a89 (1 revision) (flutter/engine#51216) 2024-03-06 [email protected] [Impeller] Fix path winding when bridging from contours with an odd number of points. (flutter/engine#51218) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
This appears to have dropped GPU frame time quite a bit? |
|
Maybe too much... |
|
@jonahwilliams Does this need an issue to track follow-up? |
|
I'm just going to revert this, I was waiting to see if this was transient at all. Either its due to a different change in the roll or this is having some odd benchmark impact that I'm not sure what to make of. |
jonahwilliams
added
the
revert
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Mar 6, 2024
…51118)" (#51244) Reverts: #51118 Initiated by: jonahwilliams Reason for reverting: unexpected performance change https://flutter-flutter-perf.skia.org/e/?queries=sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dbackdrop_filter_perf_ios__timeline_summary&selected=commit%3D39677%26name%3D%252Carch%253 Original PR Author: jonahwilliams Reviewed By: {gaaclarke} This change reverts the following previous change: Noticed this while working on the StC debugging. We can disable blending on all intermediate gaussian steps. I don't know how much of an impact this has in practice.
|
Reverted landed but benchmarks didn't change, so it might actually be a StC issue - which is the other commit. FYI @bdero |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while working on the StC debugging. We can disable blending on all intermediate gaussian steps. I don't know how much of an impact this has in practice.