Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit eee4abb

Browse files
authored
CP: Use release_build and os dimension consistently. (#42012) (#42059)
CP: 027ca79 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I signed the [CLA]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
1 parent 13f3995 commit eee4abb

File tree

1 file changed

+27
-3
lines changed

1 file changed

+27
-3
lines changed

.ci.yaml

Lines changed: 27 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -262,17 +262,23 @@ targets:
262262
properties:
263263
release_build: "true"
264264
config_name: linux_fuchsia
265+
drone_dimensions: >
266+
["os=Linux"]
265267
266268
- name: Linux linux_arm_host_engine
267269
recipe: engine_v2/engine_v2
268270
timeout: 60
269271
properties:
270272
release_build: "true"
271273
config_name: linux_arm_host_engine
274+
drone_dimensions: >
275+
["os=Linux"]
272276
273277
- name: Linux linux_host_engine
274278
recipe: engine_v2/engine_v2
275279
timeout: 60
280+
dimensions:
281+
os: "Linux"
276282
properties:
277283
release_build: "true"
278284
config_name: linux_host_engine
@@ -283,26 +289,31 @@ targets:
283289
properties:
284290
release_build: "true"
285291
config_name: linux_host_desktop_engine
292+
drone_dimensions: >
293+
["os=Linux"]
286294
287295
- name: Linux linux_android_aot_engine
288296
recipe: engine_v2/engine_v2
289297
timeout: 60
290298
properties:
291299
release_build: "true"
292300
config_name: linux_android_aot_engine
301+
drone_dimensions: >
302+
["os=Linux"]
293303
294304
- name: Linux linux_android_debug_engine
295305
recipe: engine_v2/engine_v2
296306
timeout: 60
297307
properties:
298308
release_build: "true"
299309
config_name: linux_android_debug_engine
310+
drone_dimensions: >
311+
["os=Linux"]
300312
301313
- name: Linux linux_license
302314
recipe: engine_v2/builder
303315
timeout: 60
304316
properties:
305-
release_build: "true"
306317
config_name: linux_license
307318
clobber: "true"
308319

@@ -312,12 +323,13 @@ targets:
312323
properties:
313324
release_build: "true"
314325
config_name: linux_web_engine
326+
drone_dimensions: >
327+
["os=Linux"]
315328
316329
- name: Linux linux_unopt
317330
recipe: engine_v2/engine_v2
318331
timeout: 60
319332
properties:
320-
release_build: "true"
321333
config_name: linux_unopt
322334

323335
- name: Linux Web Framework tests
@@ -375,7 +387,10 @@ targets:
375387
recipe: engine_v2/engine_v2
376388
timeout: 60
377389
properties:
390+
release_build: "true"
378391
config_name: mac_android_aot_engine
392+
drone_dimensions: >
393+
["os=Linux"]
379394
380395
- name: Mac mac_clang_tidy
381396
bringup: true
@@ -397,6 +412,8 @@ targets:
397412
]
398413
$flutter/osx_sdk : >-
399414
{ "sdk_version": "14e222b" }
415+
drone_dimensions: >
416+
["os=Mac-12"]
400417
401418
- name: Linux mac_unopt
402419
recipe: engine_v2/engine_v2
@@ -480,13 +497,14 @@ targets:
480497
[
481498
{"dependency": "jazzy", "version": "0.14.1"}
482499
]
500+
drone_dimensions: >
501+
["os=Mac-12"]
483502
484503
- name: Mac impeller-cmake-example
485504
bringup: true
486505
recipe: engine_v2/engine_v2
487506
timeout: 60
488507
properties:
489-
release_build: "true"
490508
cpu: arm64
491509
config_name: mac_impeller_cmake_example
492510

@@ -515,13 +533,17 @@ targets:
515533
properties:
516534
release_build: "true"
517535
config_name: windows_android_aot_engine
536+
drone_dimensions: >
537+
["os=Windows"]
518538
519539
- name: Windows windows_host_engine
520540
recipe: engine_v2/engine_v2
521541
timeout: 60
522542
properties:
523543
release_build: "true"
524544
config_name: windows_host_engine
545+
drone_dimensions: >
546+
["os=Windows"]
525547
526548
- name: Windows windows_arm_host_engine
527549
recipe: engine_v2/engine_v2
@@ -532,6 +554,8 @@ targets:
532554
properties:
533555
release_build: "true"
534556
config_name: windows_arm_host_engine
557+
drone_dimensions: >
558+
["os=Windows"]
535559
536560
- name: Windows windows_unopt
537561
bringup: true

0 commit comments

Comments
 (0)