Use release_build and os dimension consistently. #42012

godofredoc · 2023-05-13T05:15:33Z

Release_build property is used to signal that this build produces release artifacts that will eventually be SLSA compliant and will need to run from dart_internal.

The os property is used to select the correct drone based on the platform the build should run on.

Bug: flutter/flutter#126118
Bug: flutter/flutter#125983
Bug: flutter/flutter#126116

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Release_build property is used to signal that this build produces release artifacts that will eventually be SLSA compliant and will need to run from dart_internal. The os property is used to select the correct drone based on the platform the build should run on. Bug: flutter/flutter#126118 Bug: flutter/flutter#125983 Bug: flutter/flutter#126116

keyonghan · 2023-05-15T15:57:51Z

.ci.yaml

@@ -259,41 +259,53 @@ targets:
    bringup: true
    recipe: engine_v2/engine_v2
    timeout: 60
+    dimensions:


Shall this be drone_dimensions?

keyonghan · 2023-05-15T15:58:49Z

.ci.yaml

    properties:
      release_build: "true"
      config_name: linux_fuchsia

  - name: Linux linux_arm_host_engine
    recipe: engine_v2/engine_v2
    timeout: 60
+    dimensions:
+      os: "Linux"


We also use ubuntu, can we make them consistent?

No, this property is being used to detect the drone names, if we use ubuntu it will translate to Ubuntu Production Drone

Done_dimensions are not determining the Platform of the drone builder. It is the platform of the orchestrator builder instead.

Please take a look to: https://cs.opensource.google/flutter/recipes/+/main:recipe_modules/shard_util_v2/api.py;l=271

My bad based on a local checkout which is not up to date.

Linux should be fine then. Could we keep the Mac ones with the version to enforce same config? We do have consistent all Mac-12 in our fleet as of now, but just in case we have different versions. This makes it consistent with all other os dimension.

.ci.yaml

keyonghan · 2023-05-15T16:00:04Z

.ci.yaml

@@ -500,7 +519,6 @@ targets:
    recipe: engine_v2/engine_v2
    timeout: 60
    properties:
-      release_build: "true"


From the PR description:

Release_build property is used to signal that this build produces release artifacts that will eventually be SLSA compliant and will need to run from dart_internal.

I didn't quite follow why we need to remove here. Do we not want to run them against dart_internal any more?

Only builders generating artifacts will be running in dart-internal. Builders like "Mac impeller-cmake-example" are test only and should not run in dart-internal.

keyonghan

LGTM

…ngine#42012)

…126876) flutter/engine@00f20fb...027ca79 2023-05-15 [email protected] Use release_build and os dimension consistently. (flutter/engine#42012) 2023-05-15 [email protected] [Impeller] Add interactive DrawPaint blend test (flutter/engine#42031) 2023-05-15 [email protected] [Impeller] Limit subpass textures and backdrop blurs to the current clip (flutter/engine#42039) 2023-05-15 [email protected] Roll Dart SDK from c302a0252785 to d2b2ac829842 (1 revision) (flutter/engine#42051) 2023-05-15 [email protected] Upload xcresults to LUCI cloud storage (flutter/engine#41647) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

CP: 027ca79 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I signed the [CLA]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

…lutter#126876) flutter/engine@00f20fb...027ca79 2023-05-15 [email protected] Use release_build and os dimension consistently. (flutter/engine#42012) 2023-05-15 [email protected] [Impeller] Add interactive DrawPaint blend test (flutter/engine#42031) 2023-05-15 [email protected] [Impeller] Limit subpass textures and backdrop blurs to the current clip (flutter/engine#42039) 2023-05-15 [email protected] Roll Dart SDK from c302a0252785 to d2b2ac829842 (1 revision) (flutter/engine#42051) 2023-05-15 [email protected] Upload xcresults to LUCI cloud storage (flutter/engine#41647) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

godofredoc requested review from keyonghan, drewroengoogle and sealesj May 15, 2023 15:53

sealesj approved these changes May 15, 2023

View reviewed changes

keyonghan reviewed May 15, 2023

View reviewed changes

godofredoc added 4 commits May 15, 2023 10:22

Move to drone_dimensions.

f70ef37

Move to drone dimensions.

0c704e1

Move drone_dimensions to properties.

49a94c5

Add version to os dimension.

063cbe6

keyonghan approved these changes May 15, 2023

View reviewed changes

godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label May 15, 2023

auto-submit bot merged commit 027ca79 into flutter:main May 15, 2023

engine-flutter-autoroll mentioned this pull request May 15, 2023

Roll Flutter Engine from 00f20fbab038 to 027ca797985f (5 revisions) flutter/flutter#126876

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023

027ca7979 Use release_build and os dimension consistently. (flutter/e…

1e61689

…ngine#42012)

godofredoc deleted the add_os_dimension branch May 15, 2023 22:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use release_build and os dimension consistently. #42012

Use release_build and os dimension consistently. #42012

Uh oh!

godofredoc commented May 13, 2023

Uh oh!

keyonghan May 15, 2023

Uh oh!

godofredoc May 15, 2023

Uh oh!

keyonghan May 15, 2023

Uh oh!

godofredoc May 15, 2023

Uh oh!

keyonghan May 15, 2023

Uh oh!

godofredoc May 15, 2023

Uh oh!

keyonghan May 15, 2023

Uh oh!

Uh oh!

keyonghan May 15, 2023

Uh oh!

godofredoc May 15, 2023

Uh oh!

keyonghan left a comment

Uh oh!

Uh oh!

Use release_build and os dimension consistently. #42012

Use release_build and os dimension consistently. #42012

Uh oh!

Conversation

godofredoc commented May 13, 2023

Pre-launch Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

keyonghan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!