This repository was archived by the owner on Feb 25, 2025. It is now read-only.
make it possible to disable debug symbols stripping #11265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasten
reviewed
Aug 20, 2019
tools/gn
Outdated
| @@ -262,6 +262,10 @@ def to_gn_args(args): | |||
| if args.build_glfw_shell: | |||
| gn_args['build_glfw_shell'] = True | |||
|
|
|||
| gn_args['stripped_symbols'] = args.stripped | |||
|
|
|||
| print(gn_args) | |||
| @@ -333,6 +337,10 @@ def parse_args(args): | |||
| parser.add_argument('--bitcode', default=False, action='store_true', | |||
| help='Enable bitcode for iOS targets.') | |||
|
|
|||
| parser.add_argument('--stripped', default=True, action='store_true', | |||
There was a problem hiding this comment.
Can you change the flag name to something that indicates that this only affects the contents of flutter.jar on Android? (e.g. --flutter-jar-unstripped)
There was a problem hiding this comment.
I think the fact that it's not on iOS is probably more of a bug than a feature right? I think we should ideally not create one off features and stripping symbols is a generic feature.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 27, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 27, 2019
…engine#11265) (#39291) [email protected]:flutter/engine.git/compare/59e14bc5f69e...fd25f80 git log 59e14bc..fd25f80 --no-merges --oneline 2019-08-26 [email protected] make it possible to disable debug symbols stripping (flutter/engine#11265) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.