This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reflect selection changes in Firefox for text editing #12447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d arrow keys to move the cursor the selection change is synced to Flutter Framework
mdebbar
reviewed
Sep 25, 2019
yjbanov
reviewed
Sep 25, 2019
…angeDetection constructor.
|
Thanks a lot for the review! Please have another look. |
yjbanov
approved these changes
Sep 26, 2019
mdebbar
approved these changes
Sep 26, 2019
add initial value to selection start/end
|
Thanks for the review! I'll refactor this class in the next PR. I'll merge EditingState and selection. I'll remove EditingType. I'll also remove the unused swapdom methods. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 27, 2019
[email protected]:flutter/engine.git/compare/0018135a1c28...5b952f2 git log 0018135..5b952f2 --no-merges --oneline 2019-09-26 [email protected] Forwards Flutter View to platform views and detaches when needed. (flutter/engine#12359) 2019-09-26 [email protected] Reflect selection changes in Firefox for text editing (flutter/engine#12447) 2019-09-26 [email protected] Adds support for 5 mouse buttons (flutter/engine#12450) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
[email protected]:flutter/engine.git/compare/0018135a1c28...5b952f2 git log 0018135..5b952f2 --no-merges --oneline 2019-09-26 [email protected] Forwards Flutter View to platform views and detaches when needed. (flutter/engine#12359) 2019-09-26 [email protected] Reflect selection changes in Firefox for text editing (flutter/engine#12447) 2019-09-26 [email protected] Adds support for 5 mouse buttons (flutter/engine#12450) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflect selection changes in Firefox. With this change if the keyboard arrow keys to move the cursor the selection change is synced to Flutter Framework
Fixing issue: flutter/flutter#32225