This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Manage resource and onscreen contexts using separate IOSGLCon… #12773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text objects (flutter#12277)" This reverts commit 5a8da65.
gaaclarke
commented
Oct 3, 2019
| @@ -112,18 +93,16 @@ new AccessibilityBridge(static_cast<FlutterView*>(owner_controller_.get().view), | |||
| // |PlatformView| | |||
| std::unique_ptr<Surface> PlatformViewIOS::CreateRenderingSurface() { | |||
| if (!ios_surface_) { | |||
| ios_surface_ = CreateIOSSurface(); | |||
There was a problem hiding this comment.
This is the problem line in this CL. This is calling CreateIOSSurface directly from the platform thread. The intent of this call is to be on the GPU thread.
gw280
approved these changes
Oct 3, 2019
chinmaygarde
approved these changes
Oct 3, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2019
…IOSGLContext objects (flutter#12277)" (flutter/engine#12773)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 4, 2019
[email protected]:flutter/engine.git/compare/7d67e275ff82...8aa4732 git log 7d67e27..8aa4732 --no-merges --oneline 2019-10-03 [email protected] Fix Metal builds. (flutter/engine#12777) 2019-10-03 [email protected] Revert "Manage resource and onscreen contexts using separate IOSGLContext objects (#12277)" (flutter/engine#12773) 2019-10-03 [email protected] Roll src/third_party/dart afac6a3714..07a63a17a4 (6 commits) 2019-10-03 [email protected] roll buildroot to 01e9235 (flutter/engine#12771) 2019-10-03 [email protected] Create a package-able incremental compiler (flutter/engine#12681) 2019-10-03 [email protected] add windows embedding test (flutter/engine#12423) 2019-10-03 [email protected] Roll fuchsia/sdk/core/mac-amd64 from g-PD1... to wYLiQ... (flutter/engine#12770) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
[email protected]:flutter/engine.git/compare/7d67e275ff82...8aa4732 git log 7d67e27..8aa4732 --no-merges --oneline 2019-10-03 [email protected] Fix Metal builds. (flutter/engine#12777) 2019-10-03 [email protected] Revert "Manage resource and onscreen contexts using separate IOSGLContext objects (flutter#12277)" (flutter/engine#12773) 2019-10-03 [email protected] Roll src/third_party/dart afac6a3714..07a63a17a4 (6 commits) 2019-10-03 [email protected] roll buildroot to 01e9235 (flutter/engine#12771) 2019-10-03 [email protected] Create a package-able incremental compiler (flutter/engine#12681) 2019-10-03 [email protected] add windows embedding test (flutter/engine#12423) 2019-10-03 [email protected] Roll fuchsia/sdk/core/mac-amd64 from g-PD1... to wYLiQ... (flutter/engine#12770) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…text objects (#12277)"
This reverts commit 5a8da65.
Relevant Issue: flutter/flutter#41798