Minimal test harness for iOS #13029

dnfield · 2019-10-09T17:44:29Z

To run:

autoninja -C out/ios_debug_sim_unopt FlutterTests
open -a Simulator.app
xcrun simctl install booted out/ios_debug_sim_unopt/FlutterTests.app

Then use either Console.app or xcrun simctl spawn booted log stream, launch the app, and look at the log output.

It would probably be nicer to bootstrap this from XCTest instead.

Known issues:

springboard reruns the test when it exits currently, so you get all your logs twice.
not clear how to capture the exit code, and we're not obviously printing it anywhere that I can see.

gw280 · 2019-10-09T22:26:29Z

build/darwin/ios_app.gni

+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+template("ios_app") {


can we add an if (is_ios) here and assert if we're not ios and trying to use this template?

Good call. You can also just say assert(is_ios)

I think assert(is_ios) is fine, but we can't do what I think @gw280 is asking - we need to use this template from iOS.

gw280 · 2019-10-09T22:27:54Z

shell/platform/darwin/ios/FlutterTestsInfo.plist

+  <key>CFBundleName</key>
+  <string>FlutterTests</string>
+  <key>CFBundleVersion</key>
+  <string>1.0</string>


do we need to worry about the fact that these version strings are hardcoded?

For the case of witing a unit testing app, no. For a real app, we'd probably want better handling of the plist in general.

chinmaygarde · 2019-10-09T22:49:46Z

testing/run_all_unittests.cc

@@ -2,9 +2,22 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

+#include "flutter/fml/build_config.h"
+#include "flutter/fml/logging.h"


Nit: Unnecessary include of logging.h

chinmaygarde · 2019-10-09T22:50:19Z

shell/platform/darwin/ios/flutter_unittests.mm

+  EXPECT_EQ(1, 1);
+}
+
+TEST(SmokeTest, Fail) {


This requires a different harness.

Right now this test isn't run and nothing is tested. I wanted to see if we could somehow get the exit code from this or what log scraping might make sense for CI.

chinmaygarde · 2019-10-09T22:51:13Z

shell/platform/darwin/ios/BUILD.gn

+
+  deps = [
+    ":flutter_tests_fixtures",
+    "$flutter_root/runtime:libdart",


We can stop using flutter_root now. If you still want to use it though, please use it consistently in rules (the next dep does not use the variable here).

chinmaygarde · 2019-10-09T22:51:49Z

build/darwin/ios_app.gni

+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+template("ios_app") {


Good call. You can also just say assert(is_ios)

chinmaygarde · 2019-10-09T22:52:44Z

testing/run_all_unittests.cc

 int main(int argc, char** argv) {
+#ifdef OS_IOS
+  asl_log_descriptor(NULL, NULL, ASL_LEVEL_NOTICE, STDOUT_FILENO,


In this harness, both can be ASL_LEVEL_ERR. I don't think notices are shown by default.

In a local test they were, but I'll just make them both err.

[email protected]:flutter/engine.git/compare/ed1557f82dd4...f237896 git log ed1557f..f237896 --no-merges --oneline 2019-10-10 [email protected] Roll src/third_party/dart cc3e22f724..48e93d3d3b (8 commits) 2019-10-10 [email protected] Roll fuchsia/sdk/core/mac-amd64 from pczjK... to xd5Jj... (flutter/engine#13055) 2019-10-10 [email protected] Minimal test harness for iOS (flutter/engine#13029) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

This reverts commit 0622b05.

Minimal test harness for iOS

d4bee63

googlebot added the cla: yes label Oct 9, 2019

oops

728a59e

dnfield force-pushed the ios_test branch from 16272f2 to 728a59e Compare October 9, 2019 17:48

license

62b21d5

dnfield requested review from chinmaygarde and gw280 October 9, 2019 17:54

dnfield added 2 commits October 9, 2019 10:59

unused keys

8ae2acc

sort

68a5130

gw280 reviewed Oct 9, 2019

View reviewed changes

chinmaygarde approved these changes Oct 9, 2019

View reviewed changes

review

d8b44af

dnfield merged commit 0622b05 into flutter:master Oct 10, 2019

dnfield deleted the ios_test branch October 10, 2019 04:16

engine-flutter-autoroll mentioned this pull request Oct 10, 2019

Roll engine ed1557f82dd4..f237896bac7c (3 commits) flutter/flutter#42406

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 10, 2019

0622b05 Minimal test harness for iOS (flutter/engine#13029)

1571cc0

gaaclarke added a commit to gaaclarke/engine that referenced this pull request May 27, 2020

Revert "Minimal test harness for iOS (flutter#13029)"

9f6abba

This reverts commit 0622b05.

gaaclarke added a commit to gaaclarke/engine that referenced this pull request May 27, 2020

Revert "Minimal test harness for iOS (flutter#13029)"

1f0209a

This reverts commit 0622b05.

gaaclarke added a commit to gaaclarke/engine that referenced this pull request May 27, 2020

Revert "Minimal test harness for iOS (flutter#13029)"

7b3530b

This reverts commit 0622b05.

gaaclarke added a commit that referenced this pull request May 29, 2020

Revert "Minimal test harness for iOS (#13029)" (#18631)

17737e6

This reverts commit 0622b05.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Minimal test harness for iOS #13029

Minimal test harness for iOS #13029

Uh oh!

dnfield commented Oct 9, 2019 •

edited

Loading

Uh oh!

gw280 Oct 9, 2019

Uh oh!

chinmaygarde Oct 9, 2019

Uh oh!

dnfield Oct 9, 2019

Uh oh!

gw280 Oct 9, 2019

Uh oh!

dnfield Oct 9, 2019

Uh oh!

chinmaygarde Oct 9, 2019

Uh oh!

dnfield Oct 9, 2019

Uh oh!

chinmaygarde Oct 9, 2019

Uh oh!

dnfield Oct 9, 2019

Uh oh!

chinmaygarde Oct 9, 2019

Uh oh!

chinmaygarde Oct 9, 2019

Uh oh!

chinmaygarde Oct 9, 2019

Uh oh!

dnfield Oct 9, 2019

Uh oh!

Uh oh!

Minimal test harness for iOS #13029

Minimal test harness for iOS #13029

Uh oh!

Conversation

dnfield commented Oct 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dnfield commented Oct 9, 2019 •

edited

Loading