This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Re-add diagnostics directory to the set of remote dirs (#14566) #15094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flutter#69) This reverts commit 25349dc.
To be followed by a patch to tools/gn in the engine to eliminate overriding this value.
…lutter#76) Prevents from setting dart.exe incorrectly to read-only which causes trouble when the bot tries to delete it.
* Checkout prebuilt dart into same location where standalone dart sdk expects it. * Refactor. Remove correct folder
…r#87) Our minimum supported iOS version was 8.0. But the SDK we used was the first one returned by “xcodebuild —version —sdk”. Now we are explicit about that version too. This way, we can use newer features guarded by the appropriate version checks. If the Xcode installed on the host is too old or does not include the appropriate SDK, the GN step itself will terminate with a error.
…from //third_party. (flutter#99)
…hed if there are no changes. (#324) Fixes flutter/flutter#42021
…forms. (#323)" (#325) This reverts commit 73331c6.
…x. (#326) Unblocks flutter#13123 * We should only enable static thread safety checks for Flutter translation units. Not all third party code is correctly annotated for static checks. This will be enabled seprately in //flutter. * Allow third party users of libcxx to use RTTI (used by ICU).
This reverts commit 1c98a42.
This reverts commit b35cf60.
This new flag will be used by Skia GN rules to determine if it should be built using the Fuchsia SDK. This is to support standalone builds of Skia using the Fuchsia SDK (it could previously only be built with the Fuchsia SDK as part of Flutter).
The WEBP_EXTERN macro is overriden by Flutter because the default implementation sets symbol visibility to default instead of hidden.
SwiftShader is being rolled to 5d1e854.
- Cleanup state when roll PR is manually merged - Change merge strategy from rebase to squash to include PR #'s in commit descriptions
cbracken
changed the title
cbracken
changed the title
|
could you also incorporate the changes in #14565 to this PR? |
|
@iskakaushik done! |
miguelfrde
force-pushed
the
master
branch
2 times, most recently
from
3cce680 to
00ecc39
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4312d37. (#14470)
Once https://fuchsia-review.googlesource.com/c/topaz/+/351729 lands and rolls, the
diagnostics directory will be present, this would be safe to do and the
roller won't be blocked again.