This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "Engine/LibTxt/dart:ui impl of TextHeightBehavior #15087" #16155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 53baa7a.
|
Fixed a typo in the toString that was causing framework-side web tests to fail. |
dnfield
suggested changes
Jan 28, 2020
| 'locale: ${ _encoded[0] & 0x400 == 0x400 ? _locale : "unspecified"}' | ||
| 'textHeightBehavior: ${ | ||
| _encoded[0] & 0x040 == 0x040 ? | ||
| TextHeightBehavior.fromEncoded(_encoded[6]).toString() : "unspecified"}, ' |
There was a problem hiding this comment.
Can we update framework side tests this would break before landing it?
There was a problem hiding this comment.
That would make the framework tests fail until this can roll, which seems to result in more tree-redness than just having autoroller be stopped.
There was a problem hiding this comment.
It would also still block skia->engine since engine and framework tests are circularly dependent now.
*actually that may not be true, not sure what happens if framework is red, but engine framework tests can pass
dnfield
approved these changes
Jan 28, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2020
GaryQian
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 29, 2020
* ee297aa Reland "Engine/LibTxt/dart:ui impl of TextHeightBehavior #15087" (flutter/engine#16155) * 6007c17 Roll src/third_party/skia dc49b0ca9816..a2a0c8a2c475 (4 commits) (flutter/engine#16197)
stuartmorgan-g
pushed a commit
to stuartmorgan-g/engine
that referenced
this pull request
Jan 30, 2020
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…ter#15087" (flutter#16155)" This reverts commit b7ccc90.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reverted to unblock rolls. Land again to attempt to manually roll engine again.
Relands #15087