Roll dart to a52d6ea9b92f7c3e69c349a3c8a03d4e1cf92d4c

[aam]

Changes since last roll:

a52d6ea9b9 [dart2js] Fork backend subtyping into legacy and null-safe variants.
637a801e64 Use 'enum' and 'mixin' with undefined getters, methods, operators, setters
ca3c83b654 remove unneeded `<Widget>` assist/fix annotations
62835950d1 [vm/nnbd] Disable usage of specialized type testing stubs for NonNullable/NNBD types
c307d38af8 [vm/nnbd] Draft support for TypeRefs in CheckInstantiatedNullability
f6e0200523 [nnbd] Migrate dart:io to NNBD.
1a6a5b997d Implement FantasyRepo.
d6206fbbc7 Add return types to more tests in analysis_server
5fb7223b9a [cfe] Handle parameter type inference for mixed inheritance
9eb531bde4 [vm] Add support for real unboxed floating point fields in AOT
7248e98023 [cfe] Support nnbd platform without experiment enabled
e1e0ae5898 [cfe] Demote inferred declaration types
5d5ebb58e9 [vm] Add VM and isolate instructions start to DumpStackTrace.
7a3e1e7384 NNBD Preview: Fix region detail links to _not_ be POST links
9b6394c484 Migration: Fix toFinalType for top bounds.
e766a6f145 Use Never and Object? in NNBD bottom / top.
f24c0f0837 [VM/tests] Second step of porting dart:cli tests for NNBD
0987024f51 Revert "Implementation of evaluation to JS in frontend server"
d74aadd647 Reuse checkGetter() in checkExtension().
c053468de0 [vm, service] Add a test to exercise all timeline recorders.
344c584ec4 Implementation of evaluation to JS in frontend server
2492661ed7 Migration: Add a type parameter to NodeChange.
b1df4db728 [VM/tests] - First step to migrate dart:cli tests for NNBD.
1d4651f119 NNBD preview: Fix test for generic function types; typedefs still not fixed
de2ce18841 [vm/nnbd] Fix nullability and bounds of type parameters
28917d8b1d Handle invalid overrides in template and src dart files
0863218e02 Move changes to src .dart files to nnbd_src
f4cdc98ede Fork dom src files to nnbd version
151dc015c0 Add $#NAME syntax to emitter to allow subtemplates
e3797b1bb7 [dartdevc] Apply more lints from pedantic v1.9.0 and cleanup violations
acee34e0e8 Clean up GetterSetterTypesVerifier.
deae9152e0 [dart2js] Use HInvokeExternal for native calls
5c42f91362 Revert "[i18n] Replaces fuchsia.deprecatedtimezone"
f6c7fe278f Implement NullShortableExpressionImpl in MethodInvocationImpl.
0d3571b52f Add return types to more methods in analysis_server
124f9b3fe0 [nnbd_migration] Handle downcast from FutureOr<T> to T.
6e53629f3b [nnbd_migration] Handle LUB(Never, C<T>).
4ee5fd243f Move the parallelization restriction into SubprocessLauncher.
0ca9e8522e Migration: add explicit types to variable declarations when needed.
e0dff825b9 Migration: Add offsets to more inferred type nodes.
208d8c2e52 Migration: Rework FixAggregator to reduce order dependencies.
7467988bbc Migration: simplify edit plans for changing `?.` into `.`.
62fe052908 Migration: Make sure that /*!*/ hints and already-migrated nullabilities can't be overridden.
a49dce0631 Migration: remove the "propagation step" part of the instrumentation interface.
3182edb74e [nnbd_migration] Fix usages of migrated typedefs
b4698ffe72 Issue 39976. Treat UnknownInferredType as top.
e98085fdd8 Issue 40333. Verify types of static getters / setters.
1ec1b4d68b Completion metrics cleanup for FieldFormalParameters.
1aea141b6e In completion_metrics.dart, skip files that have analysis errors
41db525fc9 [test] Remove redundant gen_snapshot passing in crossword builder
9920801424 [vm/ffi] Split FFI tests in NNBD and legacy
071210f735 [CFE] Fix expression compilation with extensions
6199853cad [infra] Fix test runner to correctly parse android adb output and fix test to always expect compile-time error
b18b27706c [vm] Avoid inlining dynamic calls for simd operations
9eb09b64be [vm/concurrency] Add locking for any access to [FixedCache].
37d562d2a4 [vm/async] Ensure --lazy-async-stacks also works inside custom zones with error handlers
34e271a64b Don't include library directives in the completion metrics computations.
2d5265f59d [dartdevc] Apply always_declare_return_types lint and cleanup violations
220fbf2174 Update dartdevc_nnbd_sdk_error_golden.txt after analyzer error code changes.
cb2d91c983 Convert to legacy members of Object and constructor elements.
7131264848 [vm/isolates] Disallow sending of function types.
4b79594ab4 Update AnalysisDriverResolutionTest for compatibility with unforked SDK.
b3a1f053a3 Issue 40333. Extract GetterSetterTypesVerifier, report GETTER_NOT_SUBTYPE_SETTER_TYPES for NNBD.
bf6c439e9a [dart2js] SSA: Avoid emitting generate-at-use twice
7db61c6b01 Changing the dart:html generator scripts to generate null-safe/nnbd code
52da0b14f1 Revert "[vm] Initialize large typed arrays only once."
06fa701c95 [http] fix hanging when parser failed to parser body of response/request
96ff3276f4 [vmservice] allow fallback on port bind failure
833c70be61 Add the first Kernel check for invalid JS interop
2659a77444 [infra] Reduce the number of results in the pubsub messages
6fcee199af [vm] Initialize large typed arrays only once.
8efdee06d6 Begin adding return types in analysis_server
2bde0e119e Support for searching references to imports when opt-in from opt-out.
209e70b2a7 Convert loadLibrary() to legacy when opt-in from opt-out.
ac27627dd7 Do not opt-in to NNBD when building application snapshots for kernel service and other tools like dartjs, dart analyzer etc. We should enable this only when all the tools are ready to opt-in.
b1be0d58a1 completion_metrics.dart change, don't expect completions when the completed token would be a dynamic type.
f7a45a39e9 [vm/aot/tfa] Infer non-nullability of receiver after calls
efdd38b0eb Move tests for MISMATCHED_GETTER_AND_SETTER_TYPES.
fe59e25492 Add ports of the tables in steamroll_ecosystem.sh.
213c80c5dd Add a new counter in completion_metrics.dart to count and report the number of each token that was a miss.
9c04bdf1c6 bump to linter 0.1.110
ff1cd53725 completion_metrics.dart improvement with named arguments in method invocations.
534e85866d Assert that allowInterop is used with constructors
61b4bbcb6b [vm] Set non_nullable_flag() to true
85083ca5ab Enable avoid_return_types_on_setters in analysis_server
a86288a1d8 [test_runner] QEMU named configurations
dad3545c5b [test_runner] Support for arm32 VM in AOT mode on x64 via QEMU
2281c71aee [test] format test_matrix.json
14f7e334d3 [vm] Add checks to parameters of math functions before inlining
2e9eab5207 [CFE] Don't add newly-converted DillLibraryBuilders to list of needed dill libraries
49c813a41e Migration: consider edges introduced by contravariant assignment to be uncheckable.
e2e1993b94 Migartion: consider edges introduced by parameter overrides to be uncheckable.
3517d7a859 Migration: allow a node to become nullable after being marked non-nullable.
da5ab8ce00 Separate graph propagation state and results out to their own class.
6a6c000046 Migration: change NullabilityGraph._debugDump output to graphviz format.
1298313e83 Migration: improve toString representation of some inferred type nodes.
2084137a7f Migration: fix warning in edge_builder.dart.
1e01274bdf Sort methods in edge_builder_test.dart and migration_visitor_test_base.dart.
5b47e0fbb7 [cfe] Special case inference of Object.== parameter in legacy mode
e7cf75328c [cfe] Update assert to handle extension reexport
36a6b1b5ce Analyzer: Don't do recursive flattening of FutureOr in await.
cdad337d1a [co19] Roll co19 to 5a3388d1f79cc3c61f9cdc1b3eaaa405bd62c882
d7eeaed5dc [CFE] Reproduction and workaround for crash when computing variance
d21c4e4fa5 [CFE] [Incremental compiler] Convert all SourceLibraryBuilders to DillLibraryBuilders
62291efcfd [test_runner] Support for arm32 VM in JIT mode on x64 via QEMU
59e8068169 Introduce and use a new class to compute the mean reciprocal rank after a run of the code completion metrics execution.
40f23c735f [vm, docs] Describe which VM service features are available in which VM modes.
ea089033d7 [vm, gc] Use the compactor for the GC of last resort.
3e453e5adf [nnbd_migration] union resolved typedef nodes with inferred ones
c856de0747 Initial test_all.dart, the dart bots test all the files ending in "_test.dart", this file allows developers to easily run all the tests themselves.
f0038ad8aa Move MultiFutureTracker and SubprocessLauncher into utilities.
55dbf40d60 [vm/aot/tfa] Infer more information from conditions in TFA
a1a888ec92 Boilerplate and basic flow for `buildFantasyLand`.
c2fb631d99 [VM/libraries] Fix final set of warnings in dart:core and dart:typed_data
38b8dc7b21 Move dartdev command tests under a new command directory and add an initial format_test.dart
155c0d1b92 Reapply "[vm, gc] Sweep non-executable large pages concurrently."
c352c6c0b8 Cleanup and refactoring in completion_metrics.dart
a6e01c23e2 Fix more windows tests in migration tool
93c5134a69 [vm] Add nullability variations for snapshot singletons
44dff4e24b Issue 40221. NNBD_TOP_MERGE super-interfaces when checking for implementing the same generic class more than once.
548127daa1 Fix Windows analyzer tests.
3fa4194008 [vm] Update offsets
3efd623849 Fixes failure of x86_64 builds for android
0399fcf6fa Flow analysis: fix shared tests to consider potential nullability instead of nullability.
bbe5599476 [cfe] Handle promotion of nullable type variables
23fa59f8b6 [infra] Add support for builders to pkg/smith
81c5d11691 Change tests of lint-based quick fixes to not require the lint marker in the result
b6fdba235e Update NORM and type parameters handling to new understanding.
7494f58032 Enable always_declare_return_types in analyzer_plugin
7d7643c2ad Add newly reviewed docs and change section header everywhere
61199914d7 Convert dartfix to use underscores rather than hyphens for fix names
36e3bae4fb Enable always_declare_return_types in analyzer_cli
d29c5c174c Refactor dartfix to make the handling of lint fixes uniform
f5abdf27a7 Split NormalizeHelper.
7ebfc3662f Extract NORM implementation into NormalizeHelper.
9609975262 Update generators to not produce type annotations for variable declarations
9918987c59 Enable prefer_if_null_operators and prefer_spread_collections in analysis_server
6b34a69496 [dart2js] Cleanup of a few dynamic calls
5f780997a2 [dart2js] Redirecting a selector should clear cached element
5d0c08b5de [VM/libraries] Port some of the changes made in the sdk version of typed_data_patch.dart over to the sdk_nnbd version too.
4cc45ec612 Cleanup some analyzer hints
d3070f4bbc - simplify convertFileOrArgumentToUri to just use resolveInputUri - Allow non-file uris as a multi-root root
e2a899e965 [dart2js] Add regression test for #40296.
21ab021637 Use test Matcher for checking Element(s).
a20c9de3e8 [benchmarks] Add typed data copy benchmark
17fff9b721 [vm] Generate different offsets for dart_precompiled_runtime
cdeb9a7a8c Revert "[vmservice] allow fallback on port bind failure"
318e8556e0 Issue 39917. Test that Never is resolved as Never* in legacy.
3f12134e60 Issue 40287. Don't report MISSING_DEFAULT_VALUE_FOR_PARAMETER for external and native methods.
4f516c61c8 [dart2js] Redirect all subclasses of JavaScriptObject.
ae372d68ee Move old AnalysisDriverResolutionTest to DriverResolutionTest.
fb36ed007d [nnbd_migration] CompletenessTracker to ensure EdgeBuilder visits all types.
3ab0defd92 [nnbd_migration] visit type names in type arguments
9bd7eb62c2 [nnbd_migration] Don't visit spread elements twice
482ea3c619 [nnbd_migration] fix typo in instrumentation test
11fa5a5322 [nnbd_migration] visit type names in factory constructors
1d96bfcbe9 [nnbd_migration] visit type names in method type parameter bounds
955e64bd6b [nnbd_migration] visit types in typed field formal parameters
1c7ac2dce3 [nnbd_migration] visit type names in class aliases
dd6829de6e [nnbd_migration] visit type names in mixin type parameter bounds
5e23a103e9 [nnbd_migration] visit type names in extension extended type
36451c85a2 [nnbd_migration] visit type names in for-in loops (&test regular for)
1ae7b6655e [nnbd_migration] visit type names in explicit invocation arguments
989fd9a628 [nnbd_migration] visit type names in instance creation parameters
ea14c4dee0 [nnbd_migration] visit type names in list, set, map literals
428fd51e19 [nnbd_migration] visit type names in method type parameter bounds
e9c26045c3 [nnbd_migration] Visit types names in local variables
e6249d3667 [nnbd_migration] visit type names in type parameter bounds
d528bf9e13 [nnbd_migration] visit type names in extends/implements
5dafbe741b [nnbd_migration] visit type names in as casts
08a0e830e1 [nnbd_migration] visit TypeNames for function return types
a067265272 [vm] Scrub and qualify names without allocating on the Dart heap.
37b74bd1a3 Cleanup status file entries for service/dartkp crashes
6ff7e9ebad [vmservice] allow fallback on port bind failure
691df73a15 Issue 40287. Don't report MISSING_DEFAULT_VALUE_FOR_PARAMETER for abstract methods.
bd6cd9cd3a [test] Move and migrate `dart:profiler` tests.
782c83fe5a [dart2js] Fix incorrect SideEffects for native members
4078b3b352 Don't run pkg/dartdev/test/command_test on dart2js
4a42831e85 Use source-maps in test runner to expand JavaScript stack traces.
2edd8d17c0 Migration: replace `?.` with `.` where appropriate.
8714a7fa1d Abstract resolution calls to `.isNullAware`.
aa1b00d668 Reland "[vm] resolve symbolic link to find kernel_service snapshot"
22d55c39d8 [VM/libraries] Fix final set of warnings from dart:async patch files.
8ebe354ecc fix diagnostic messages for named constructors
89fb48c648 add mixed subtype test
c9b56d3530 Remove support for default fixes from dartfix
1960cef002 [io/file_watcher] Unregister watched pathId when handle is closed.
4d839404c9 Updating iterable.current comments and behavior to be consistent.
322b2493b7 NNBD preview: Fix recent display issues; fixes #40307
2b221f9b49 Require pre-initialized importToSummary and summaryToModule maps in the ProgramCompiler constructor, and remove the corresponding arguments from emitModule.
a0a0580a56 Update iterator.dart to fully spec moveNext()
300876faf4 Add Requirements to run this test only in the mode where it makes sense
95511b314c Stop using List() constructor in NNBD code.
41b0a6b8c0 [vm/ffi] Split up compiler/ffi.cc into separate files
811ae9eb8d Sort declarations in api_test.dart
9ac5aabe77 Fix an incorrect type annotation (issue 40299)
4b9887b406 Correct date of v2.7.1 release (32nd -> 23rd Jan)
d370cabc5e [cfe] Report errors on supertypes marked with "?"
e4048261c2 [cfe] Compute correct type for read of late lowered variables
00dc17687a [cfe] Handle late variables in for loops
0a771440dd [cfe] Using isSameType in override checking of bounds
173ae210d1 [SDK] Fixes service/break_on_default_constructor_test for --lazy-async-stacks.
a4aaaf05eb [vm] Cleanups in the native_stack_traces package.
b2de23d88d [CFE] Messages test doesn't allow status updates for spelling tests

[chinmaygarde]

@rmistry says this roll #16261 has the latest fixes in. Can we wait for that one instead? I'd be good to verify that the roller is capable on its own.

[aam]

@rmistry says this roll #16261 has the latest fixes in. Can we wait for that one instead? I'd be good to verify that the roller is capable on its own.

Sure, let's do that.