Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Disable unit tests using --gtest-filter instead of at compile time #16472

Merged
merged 2 commits into from
Feb 6, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 5 additions & 17 deletions fml/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -230,9 +230,14 @@ executable("fml_unittests") {
sources = [
"base32_unittest.cc",
"command_line_unittest.cc",
"file_unittest.cc",
"gpu_thread_merger_unittests.cc",
"memory/ref_counted_unittest.cc",
"memory/weak_ptr_unittest.cc",
"message_loop_task_queues_merge_unmerge_unittests.cc",
"message_loop_task_queues_unittests.cc",
"message_loop_unittests.cc",
"message_unittests.cc",
"paths_unittests.cc",
"platform/darwin/string_range_sanitization_unittests.mm",
"synchronization/count_down_latch_unittests.cc",
Expand All @@ -246,23 +251,6 @@ executable("fml_unittests") {
"time/time_unittest.cc",
]

# TODO(https://github.com/flutter/flutter/issues/50032) Enable after the
# Fuchsia message loop migration is complete.
if (!is_fuchsia) {
sources += [
"message_loop_task_queues_merge_unmerge_unittests.cc",
"message_loop_task_queues_unittests.cc",
"message_loop_unittests.cc",
"message_unittests.cc",
]
}

# TODO(https://github.com/flutter/flutter/issues/50031):
# Figure out why these tests don't work currently on Fuchsia
if (!is_fuchsia) {
sources += [ "file_unittest.cc" ]
}

deps = [
":fml_fixtures",
"//flutter/fml",
Expand Down
3 changes: 3 additions & 0 deletions testing/fuchsia/run_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,12 @@ done
-f flutter_runner_scenic_tests-0.far \
-t flutter_runner_scenic_tests

# TODO(https://github.com/flutter/flutter/issues/50032) Enable after the
# Fuchsia message loop migration is complete.
./fuchsia_ctl -d $device_name test \
-f fml_tests-0.far \
-t fml_tests
-a "--gtest_filter=-MessageLoop*:Message*:FileTest*"

./fuchsia_ctl -d $device_name test \
-f flow_tests-0.far \
Expand Down