This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Code cleanup on destructors #16481
Merged
Code cleanup on destructors #16481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
approved these changes
Feb 7, 2020
franciscojma86
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 7, 2020
dnfield
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 7, 2020
* 71ec0a1 Relax timing restrictions on WakeUpTimersAreSingletons. (flutter/engine#16446) * 3ac1e6d Disable unit tests using --gtest-filter instead of at compile time (flutter/engine#16472) * 80be2c4 Fix RasterCache LRU logic, opportunistic simplifications. (flutter/engine#16434) * ca40f11 Roll src/third_party/skia 7f36405ea3ec..c0360582d211 (6 commits) (flutter/engine#16476) * c9e7713 Fix analyzer warnings for frontend_server change (flutter/engine#16470) * 9ada1b0 Fix elf_loader.cc on Fuchsia, add a TODO for proper fix * 0517627 Enable runtime_unittests on Fuchsia * 03f639e Add noexcept annotations to EnableValue moves (flutter/engine#16478) * 00904dd Various fixes in CanvasKit (flutter/engine#16433) * de7022b Roll src/third_party/skia c0360582d211..121750c2efff (7 commits) (flutter/engine#16479) * d2aab27 Enable shell_unittests on Fuchsia with Vulkan dependencies. (flutter/engine#16376) * eec73e3 Roll src/third_party/dart b3396cbdcae1..49850e6919f7 (45 commits) (flutter/engine#16480) * 557f3a2 Run Flutter framework tests against the web engine in Cirrus (flutter/engine#16343) * 477527b Roll src/third_party/skia 121750c2efff..046f9893b953 (4 commits) (flutter/engine#16482) * eb8691f Code cleanup on destructors (flutter/engine#16481) * 7397817 Roll fuchsia/sdk/core/linux-amd64 from A9STP... to g2s3c... (flutter/engine#16484) * 313527d Roll src/third_party/dart 49850e6919f7..16782e6c171f (16 commits) (flutter/engine#16485) * 83feaf4 Roll src/third_party/skia 046f9893b953..97bf6578796c (1 commits) (flutter/engine#16486) * 9184058 Roll src/third_party/skia 97bf6578796c..f3560b680e35 (1 commits) (flutter/engine#16487) * 0db017d Roll src/third_party/dart 16782e6c171f..d765d237460d (1 commits) (flutter/engine#16488) * f9ed07c Roll fuchsia/sdk/core/linux-amd64 from g2s3c... to LvSlH... (flutter/engine#16489) * a1b91da Roll src/third_party/skia f3560b680e35..77fdf66946d2 (1 commits) (flutter/engine#16490) * 7edb803 Roll src/third_party/dart d765d237460d..514a8d4c8417 (7 commits) (flutter/engine#16491) * 580503c Roll src/third_party/skia 77fdf66946d2..87e3bef6f82f (2 commits) (flutter/engine#16492)
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
This reverts commit 8f2cbb3.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught some issues while adding new tests caused by destroying the window from a non-virtual destructor in a base class.