Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Running safari tests on LUCI #16715

Merged
merged 5 commits into from
Feb 21, 2020
Merged

[web] Running safari tests on LUCI #16715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c0a6a05
Safari font collection tests skip failing methods
Feb 20, 2020
f83fd4f
add a clear to the semantics test to make sure no DOM elements are le…
Feb 20, 2020
12895dd
fix semantics_helper_test. skip for semantics_test. teardown didn't work
Feb 21, 2020
351b605
skip test, the skipped method run for 8 minutes according to the logs
Feb 21, 2020
f1bbd99
history tests methods runs multiple times. only run them on linux for…
Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/web_ui/test/engine/history_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// found in the LICENSE file.

// @dart = 2.6
@TestOn('vm && linux')

import 'dart:async';
import 'dart:typed_data';

Expand Down Expand Up @@ -158,7 +160,8 @@ void main() {
expect(strategy.currentEntryIndex, -1);
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/50836
skip: browserEngine == BrowserEngine.edge);
skip: browserEngine == BrowserEngine.edge ||
browserEngine == BrowserEngine.webkit);

test('handle user-provided url', () async {
strategy =
Expand Down
11 changes: 7 additions & 4 deletions lib/web_ui/test/engine/semantics/semantics_helper_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,14 @@ void main() {

expect(shouldForwardToFramework, true);

event = html.PointerEvent('pointermove');
shouldForwardToFramework =
desktopSemanticsEnabler.tryEnableSemantics(event);
// Pointer events are not defined in webkit.
if (browserEngine != BrowserEngine.webkit) {
event = html.PointerEvent('pointermove');
shouldForwardToFramework =
desktopSemanticsEnabler.tryEnableSemantics(event);

expect(shouldForwardToFramework, true);
expect(shouldForwardToFramework, true);
}
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/50754
skip: browserEngine == BrowserEngine.edge);
Expand Down
20 changes: 15 additions & 5 deletions lib/web_ui/test/engine/semantics/semantics_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,8 +396,10 @@ void _testVerticalScrolling() {

semantics().semanticsEnabled = false;
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/50590
// TODO(nurhan): https://github.com/flutter/flutter/issues/50754
skip: browserEngine == BrowserEngine.edge);
skip: browserEngine == BrowserEngine.webkit ||
browserEngine == BrowserEngine.edge);

test('scrollable node with children has a container node', () async {
semantics()
Expand Down Expand Up @@ -432,8 +434,10 @@ void _testVerticalScrolling() {

semantics().semanticsEnabled = false;
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/50590
// TODO(nurhan): https://github.com/flutter/flutter/issues/50754
skip: browserEngine == BrowserEngine.edge);
skip: browserEngine == BrowserEngine.webkit ||
browserEngine == BrowserEngine.edge);

test('scrollable node dispatches scroll events', () async {
final StreamController<int> idLogController = StreamController<int>();
Expand Down Expand Up @@ -544,8 +548,10 @@ void _testHorizontalScrolling() {

semantics().semanticsEnabled = false;
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/50590
// TODO(nurhan): https://github.com/flutter/flutter/issues/50754
skip: browserEngine == BrowserEngine.edge);
skip: browserEngine == BrowserEngine.webkit ||
browserEngine == BrowserEngine.edge);

test('scrollable node with children has a container node', () async {
semantics()
Expand Down Expand Up @@ -580,8 +586,10 @@ void _testHorizontalScrolling() {

semantics().semanticsEnabled = false;
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/50590
// TODO(nurhan): https://github.com/flutter/flutter/issues/50754
skip: browserEngine == BrowserEngine.edge);
skip: browserEngine == BrowserEngine.webkit ||
browserEngine == BrowserEngine.edge);

test('scrollable node dispatches scroll events', () async {
final SemanticsActionLogger logger = SemanticsActionLogger();
Expand Down Expand Up @@ -1140,8 +1148,10 @@ void _testTappable() {

semantics().semanticsEnabled = false;
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/50590
// TODO(nurhan): https://github.com/flutter/flutter/issues/50754
skip: browserEngine == BrowserEngine.edge);
skip: browserEngine == BrowserEngine.webkit ||
browserEngine == BrowserEngine.edge);
}

void _testImage() {
Expand Down
20 changes: 15 additions & 5 deletions lib/web_ui/test/text/font_collection_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ void main() {
expect(fontFamilyList.first, 'Ahem ahem ahem');
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/50770
skip: browserEngine == BrowserEngine.edge);
// TODO(nurhan): https://github.com/flutter/flutter/issues/51142
skip: browserEngine == BrowserEngine.edge ||
browserEngine == BrowserEngine.webkit);

test('Register Asset with capital case letters', () async {
final String _testFontFamily = "AhEm";
Expand Down Expand Up @@ -101,7 +103,9 @@ void main() {
}
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/50770
skip: browserEngine == BrowserEngine.edge);
// TODO(nurhan): https://github.com/flutter/flutter/issues/51142
skip: browserEngine == BrowserEngine.edge ||
browserEngine == BrowserEngine.webkit);

test('Register Asset twice with exclamation mark', () async {
final String _testFontFamily = 'Ahem!!ahem';
Expand All @@ -125,7 +129,9 @@ void main() {
}
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/50770
skip: browserEngine == BrowserEngine.edge);
// TODO(nurhan): https://github.com/flutter/flutter/issues/51142
skip: browserEngine == BrowserEngine.edge ||
browserEngine == BrowserEngine.webkit);

test('Register Asset twice with comma', () async {
final String _testFontFamily = 'Ahem ,ahem';
Expand All @@ -149,7 +155,9 @@ void main() {
}
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/50770
skip: browserEngine == BrowserEngine.edge);
// TODO(nurhan): https://github.com/flutter/flutter/issues/51142
skip: browserEngine == BrowserEngine.edge ||
browserEngine == BrowserEngine.webkit);

test('Register Asset twice with a digit at the start of a token',
() async {
Expand All @@ -174,7 +182,9 @@ void main() {
}
},
// TODO(nurhan): https://github.com/flutter/flutter/issues/50770
skip: browserEngine == BrowserEngine.edge);
// TODO(nurhan): https://github.com/flutter/flutter/issues/51142
skip: browserEngine == BrowserEngine.edge ||
browserEngine == BrowserEngine.webkit);
});
});
}