This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Drop last usages of Dart_New from engine #16838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
force-pushed
the
picture_dart
branch
from
3d6bcc6 to
58778cc
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2020
This was referenced Mar 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2020
This was referenced Mar 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2020
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Mar 3, 2020
We believe this may be implicated in a Windows-specific crash during the Flutter Gallery integration test. See: flutter/flutter#51896 This reverts commit f9b78c5.
cbracken
added a commit
that referenced
this pull request
Mar 3, 2020
We believe this may be implicated in a Windows-specific crash during the Flutter Gallery integration test. See: flutter/flutter#51896 This reverts commit f9b78c5.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 4, 2020
cbracken
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 4, 2020
* 04fa001 Roll src/third_party/skia 8121d27b297c..73ae40a424fa (1 commits) (flutter/engine#16900) * f9b78c5 Drop last usages of Dart_New from engine (flutter/engine#16838) * 0795be8 Roll src/third_party/skia 73ae40a424fa..b19408040143 (4 commits) (flutter/engine#16901) * 2c5145e Roll src/third_party/dart ca3ad264a649..06155d499645 (3 commits) (flutter/engine#16902) * 7ca9bf0 Roll fuchsia/sdk/core/mac-amd64 from WmA2M... to cGxwD... (flutter/engine#16903) * 44ed690 Roll src/third_party/dart 06155d499645..c07d5d84b828 (3 commits) (flutter/engine#16904) * 00d7794 Roll src/third_party/skia b19408040143..853789cdfe3c (1 commits) (flutter/engine#16905) * 922e257 Roll src/third_party/skia 853789cdfe3c..96c2eb6258ae (3 commits) (flutter/engine#16906) * e027340 Roll fuchsia/sdk/core/linux-amd64 from uiAI5... to ULy6Z... (flutter/engine#16907) * 5fdfc12 Roll src/third_party/skia 96c2eb6258ae..b58098f34c56 (2 commits) (flutter/engine#16908) * 66bac1c Roll src/third_party/dart c07d5d84b828..e7e45599cb1a (9 commits) (flutter/engine#16909) * 0f7b14f Roll src/third_party/skia b58098f34c56..ae2da5e7f9b5 (3 commits) (flutter/engine#16910) * 224e0f9 Roll src/third_party/skia ae2da5e7f9b5..964aa91580b6 (4 commits) (flutter/engine#16911) * ca8bb0a Roll src/third_party/skia 964aa91580b6..4036cb1f0b6e (5 commits) (flutter/engine#16912) * ba8a892 Roll src/third_party/dart e7e45599cb1a..5701c4fd3b11 (25 commits) (flutter/engine#16913) * 78a1c7e Revert "Drop last usages of Dart_New from engine (#16838)" (flutter/engine#16915)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the changes from #16837
This is meant to validate that we can remove all usages of Dart_New from the engine. I intend to land 16837 before this, and merge it in, so that this patch covers only images and removing the code from tonic.
This will have merge conflicts between #16824 depending on which lands first.
/cc @chinmaygarde @jason-simmons FYI.
This fixes flutter/flutter#50997