This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Try rasterizing images and layers only once , even when their… #16889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rasterization fails. Further enforce the same access threshold on layers as on Pictures. Previously layers would always be cached. The latter is a semantic change. (#16545)" This caused regression in several benchmarks, including: animated_placeholder_perf. Regression tracked in flutter/flutter#51776. This reverts commit 01a52b9.
|
/cc @ignatz |
tvolkert
approved these changes
Mar 2, 2020
cbracken
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 2, 2020
…en their rasterization fails. Further enforce the same access threshold on layers as on Pictures. Previously layers would always be cached. The latter is a semantic change. (flutter#16545)" (flutter/engine#16889)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 2, 2020
…en their rasterization fails. Further enforce the same access threshold on layers as on Pictures. Previously layers would always be cached. The latter is a semantic change. (flutter#16545)" (flutter/engine#16889)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 2, 2020
…en their rasterization fails. Further enforce the same access threshold on layers as on Pictures. Previously layers would always be cached. The latter is a semantic change. (flutter#16545)" (flutter/engine#16889)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2020
…en their rasterization fails. Further enforce the same access threshold on layers as on Pictures. Previously layers would always be cached. The latter is a semantic change. (flutter#16545)" (flutter/engine#16889)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2020
…en their rasterization fails. Further enforce the same access threshold on layers as on Pictures. Previously layers would always be cached. The latter is a semantic change. (flutter#16545)" (flutter/engine#16889)
This was referenced Mar 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2020
…en their rasterization fails. Further enforce the same access threshold on layers as on Pictures. Previously layers would always be cached. The latter is a semantic change. (flutter#16545)" (flutter/engine#16889)
cbracken
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 3, 2020
* 38f497c Roll src/third_party/skia 9dd0bd78b2d7..470f0637aeea (11 commits) (flutter/engine#16887) * 5073cc7 Roll src/third_party/dart fbe9f6115d2f..0b819161d778 (3 commits) (flutter/engine#16888) * df94213 Revert "Try rasterizing images and layers only once , even when their rasterization fails. Further enforce the same access threshold on layers as on Pictures. Previously layers would always be cached. The latter is a semantic change. (#16545)" (flutter/engine#16889) * b230adb Roll src/third_party/skia 470f0637aeea..ded437003d0e (6 commits) (flutter/engine#16891) * 63bdf3e Roll fuchsia/sdk/core/mac-amd64 from q2DAy... to WmA2M... (flutter/engine#16892) * e54f2c8 Const finder missing `static const` list/map/set fields. (flutter/engine#16896) * 10275fe Roll fuchsia/sdk/core/linux-amd64 from 9NHsJ... to uiAI5... (flutter/engine#16893) * 8d046fa Roll src/third_party/skia ded437003d0e..b43cfa4d3f96 (7 commits) (flutter/engine#16894) * 9c53993 Roll src/third_party/dart 0b819161d778..ca3ad264a649 (18 commits) (flutter/engine#16898) * 6991dd9 Roll src/third_party/skia b43cfa4d3f96..8121d27b297c (10 commits) (flutter/engine#16899)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… rasterization fails. Further enforce the same access threshold on layers as on Pictures. Previously layers would always be cached. The latter is a semantic change. (#16545)"
This caused regression in several benchmarks, including:
animated_placeholder_perf. Regression tracked in
flutter/flutter#51776.
This reverts commit 01a52b9.