Add Flutter RTree #16923
Add Flutter RTree #16923
Conversation
|
Would be easier to review if the delta from Skia's implementation is visible. Any chance you can split this into 2 commits one is a pure copy and the other is the actual delta? I'm not sure if we have any precedence of copying over some non-trivial Skia code, as this essentially becomes part of Flutter's codebase now should we copy over Skia's unit tests as well? (@chinmaygarde what's your take?) Did we check whether Skia are willing to make the RTree public? in that case would we be able to land our changes in a subclass? |
blasten
force-pushed
the
flutter_rtree
branch
4 times, most recently
from
04a1693 to
41e8c93
Compare
|
As discussed offline, I moved the rtree to third_party/skia. I pushed two commits: 7800778 is the fork from Skia, dd54c47 the implementation of the searchRect method, and additional tests in 7cc254a and 47731ae. @amirha raised a concern about changing the code too much, so I copied the In the meanwhile, I have filed flutter/flutter#52000 to keep track of the remaining work. If this plan sounds ok, please take another look when you get a chance. @chinmaygarde @amirh. |
There was a problem hiding this comment.
My understanding of the work items as discussed offline was:
- We are going to be sole owners of this component moving forward.
- Due to the compressed timeline of this deliverable, we are not going to reformat this to follow engine style guides. Instead, we will file a bug to tackle this tech debt at a later time.
- We are going to thoroughly document the public methods and the expected behavior via Doxygen comments (as we not familiar with the internals of this component but we are now tasked with owning it).
Other construction issues added inline.
There was a problem hiding this comment.
Reviewed only the delta from Skia's implementation (blasten/engine@7800778...4440e96#diff-6adb5cf35e31186258beded1d7d56102R229 )
| recording_canvas->drawRect(SkRect::MakeLTRB(20, 20, 40, 40), rect_paint); | ||
| recorder->finishRecordingAsPicture(); | ||
|
|
||
| auto hits = r_tree->searchRects(SkRect::MakeLTRB(40, 40, 80, 80)); |
There was a problem hiding this comment.
Doesn't this test case means the platform views has a single pixel intersection with the drawing? (pixel 40, 40)
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Not sure I follow, does it mean that due to this rtree implementation we will end up with pixel that should be drawn on top of a platform view but will instead be drawn below?
There was a problem hiding this comment.
It looks like the bounds are exclusive: https://fiddle.skia.org/c/7c60511e363665b7588c8bf262220005
There was a problem hiding this comment.
To your point, I don't think any pixels will be drawn on the overlay, since the height will be 0 in this case.
There was a problem hiding this comment.
In your example, (40, 40, 80, 80) platform view and (20, 20, 40, 40) blue rectangle on top should result in no overlay. The size of this intersection is the equivalent of the rect: (40, 40, 40, 40), which is empty. This is my understanding, but I could be wrong. I can ask the Skia folks to confirm.
There was a problem hiding this comment.
What should be the color of the pixel at (40,40) in the example above with the red platform view and the blue overlay?
There was a problem hiding this comment.
The right and bottom values are exclusive. The pixel at (40,40,41,41) is the platform view itself
There was a problem hiding this comment.
I'm not convinced that a flow platform_view layer that positions a platform view at 0,0, with no transforms will result in the platform view positioned on the screen at (1,1).
Anyway it's a matter of what values we pass in, to my current understanding we need to query for a bigger rect than the actual platform view, but I may very well be missing something. The discussion of what to pass in belongs in the next PR. For this PR lets make sure the comment is explicit about not including the query's edges.
There was a problem hiding this comment.
resolved offline. SkRect::MakeLTRB(0,0,1,1) paints 1 pixel.
2020-03-11 [email protected] Roll src/third_party/dart 4093d08271f6..37530145ff53 (4 commits) (flutter/engine#17090) 2020-03-11 [email protected] Roll src/third_party/skia bf355123ae3b..0340292972b9 (9 commits) (flutter/engine#17089) 2020-03-11 [email protected] Roll fuchsia/sdk/core/mac-amd64 from r_oCI... to 0Z8VF... (flutter/engine#17087) 2020-03-11 [email protected] Roll fuchsia/sdk/core/linux-amd64 from v32mJ... to X3Xm2... (flutter/engine#17086) 2020-03-11 [email protected] Remove the unused method on iOS surface to make the resource context current. (flutter/engine#17084) 2020-03-11 [email protected] Revert "Add support for the Metal backend on all iOS builds. (flutter#17080)" (flutter/engine#17088) 2020-03-11 [email protected] Roll src/third_party/dart ace1d9b9213a..4093d08271f6 (12 commits) (flutter/engine#17082) 2020-03-11 [email protected] Add support for the Metal backend on all iOS builds. (flutter/engine#17080) 2020-03-11 [email protected] Roll src/third_party/skia d3f67dbf9f36..bf355123ae3b (9 commits) (flutter/engine#17079) 2020-03-11 [email protected] Disable Embedder11yTest::A11yTreeIsConsistent to unblock LUCI. (flutter/engine#17081) 2020-03-10 [email protected] Gather demangled stack traces and report the same to console on crashes. (flutter/engine#16450) 2020-03-10 [email protected] Implement asynchronous texture uploads when using the Metal backend on iOS. (flutter/engine#17046) 2020-03-10 [email protected] Roll src/third_party/dart 97674262bc29..ace1d9b9213a (14 commits) (flutter/engine#17078) 2020-03-10 [email protected] Add RTree to flow (flutter/engine#16923) 2020-03-10 [email protected] Roll src/third_party/skia 78dac6dcb222..d3f67dbf9f36 (6 commits) (flutter/engine#17072) 2020-03-10 [email protected] Revert "Fix bounds of image_filter_layer (flutter#16960)" (flutter/engine#17074) 2020-03-10 [email protected] Use the ELF loader to setup AOT symbols in benchmark runner. (flutter/engine#17051) 2020-03-10 [email protected] Roll src/third_party/skia 23899c64e3db..78dac6dcb222 (19 commits) (flutter/engine#17069) 2020-03-10 [email protected] Roll dart to 97674262bc29447dc59d5c93024b18b27d4bcf98. (flutter/engine#17067) 2020-03-10 [email protected] [web] Fixes for Firefox & Safari double underline decoration bugs. (flutter/engine#16994) 2020-03-10 [email protected] Avoid capturing this unsafely in MultiFrameCodec (flutter/engine#16824) 2020-03-10 [email protected] Revert "Revert "fix shadows and mask filter blurs (flutter#16963)" (flutter#17008)" (flutter/engine#17040) 2020-03-10 [email protected] Add support for firefox mac installer. Update web_ui pubspec for http.wq (flutter/engine#17044) 2020-03-09 [email protected] fix "TREE INCONSISTENT" noise in compositing_test.dart (flutter/engine#16995) 2020-03-09 [email protected] Add more child lifecycle tests (flutter/engine#16689) 2020-03-09 [email protected] Add libfreetype6-dev to desktop Linux dependencies (flutter/engine#17020) 2020-03-09 [email protected] Disable shell benchmarks (flutter/engine#17038) 2020-03-09 [email protected] Fix bounds of image_filter_layer (flutter/engine#16960) 2020-03-09 [email protected] Record fml and shell benchmarks (flutter/engine#16991) 2020-03-09 [email protected] Roll src/third_party/skia c56950442dd1..23899c64e3db (11 commits) (flutter/engine#17033) 2020-03-09 [email protected] use commit date instead of author date (flutter/engine#17032)
2020-03-11 [email protected] Roll src/third_party/dart 4093d08271f6..37530145ff53 (4 commits) (flutter/engine#17090) 2020-03-11 [email protected] Roll src/third_party/skia bf355123ae3b..0340292972b9 (9 commits) (flutter/engine#17089) 2020-03-11 [email protected] Roll fuchsia/sdk/core/mac-amd64 from r_oCI... to 0Z8VF... (flutter/engine#17087) 2020-03-11 [email protected] Roll fuchsia/sdk/core/linux-amd64 from v32mJ... to X3Xm2... (flutter/engine#17086) 2020-03-11 [email protected] Remove the unused method on iOS surface to make the resource context current. (flutter/engine#17084) 2020-03-11 [email protected] Revert "Add support for the Metal backend on all iOS builds. (#17080)" (flutter/engine#17088) 2020-03-11 [email protected] Roll src/third_party/dart ace1d9b9213a..4093d08271f6 (12 commits) (flutter/engine#17082) 2020-03-11 [email protected] Add support for the Metal backend on all iOS builds. (flutter/engine#17080) 2020-03-11 [email protected] Roll src/third_party/skia d3f67dbf9f36..bf355123ae3b (9 commits) (flutter/engine#17079) 2020-03-11 [email protected] Disable Embedder11yTest::A11yTreeIsConsistent to unblock LUCI. (flutter/engine#17081) 2020-03-10 [email protected] Gather demangled stack traces and report the same to console on crashes. (flutter/engine#16450) 2020-03-10 [email protected] Implement asynchronous texture uploads when using the Metal backend on iOS. (flutter/engine#17046) 2020-03-10 [email protected] Roll src/third_party/dart 97674262bc29..ace1d9b9213a (14 commits) (flutter/engine#17078) 2020-03-10 [email protected] Add RTree to flow (flutter/engine#16923) 2020-03-10 [email protected] Roll src/third_party/skia 78dac6dcb222..d3f67dbf9f36 (6 commits) (flutter/engine#17072) 2020-03-10 [email protected] Revert "Fix bounds of image_filter_layer (#16960)" (flutter/engine#17074) 2020-03-10 [email protected] Use the ELF loader to setup AOT symbols in benchmark runner. (flutter/engine#17051) 2020-03-10 [email protected] Roll src/third_party/skia 23899c64e3db..78dac6dcb222 (19 commits) (flutter/engine#17069) 2020-03-10 [email protected] Roll dart to 97674262bc29447dc59d5c93024b18b27d4bcf98. (flutter/engine#17067) 2020-03-10 [email protected] [web] Fixes for Firefox & Safari double underline decoration bugs. (flutter/engine#16994) 2020-03-10 [email protected] Avoid capturing this unsafely in MultiFrameCodec (flutter/engine#16824) 2020-03-10 [email protected] Revert "Revert "fix shadows and mask filter blurs (#16963)" (#17008)" (flutter/engine#17040) 2020-03-10 [email protected] Add support for firefox mac installer. Update web_ui pubspec for http.wq (flutter/engine#17044) 2020-03-09 [email protected] fix "TREE INCONSISTENT" noise in compositing_test.dart (flutter/engine#16995) 2020-03-09 [email protected] Add more child lifecycle tests (flutter/engine#16689) 2020-03-09 [email protected] Add libfreetype6-dev to desktop Linux dependencies (flutter/engine#17020) 2020-03-09 [email protected] Disable shell benchmarks (flutter/engine#17038) 2020-03-09 [email protected] Fix bounds of image_filter_layer (flutter/engine#16960) 2020-03-09 [email protected] Record fml and shell benchmarks (flutter/engine#16991) 2020-03-09 [email protected] Roll src/third_party/skia c56950442dd1..23899c64e3db (11 commits) (flutter/engine#17033) 2020-03-09 [email protected] use commit date instead of author date (flutter/engine#17032)
This PR adds the Flutter R-tree, which is based on https://chromium.googlesource.com/skia/+/master/src/core/SkRTree.h.
For context about how this is used, refer to http://go/flutter-hybrid-composition and #17049.