fix shadows and mask filter blurs #16963

yjbanov · 2020-03-05T22:16:01Z

Our original implementation of shadows was based on the AngularDart version, which doesn't match Flutter at all.

This new implementation is based on Flutter's physical_shape_layer.cc (not 100% as we don't get to use Skia's DrawShadow directly). Rendering should be slightly faster too as we emulate it using a single shadow rather than 3 shadows from the previous implementation.
Fixes bounds estimation for drawShadow.
Fixes bounds estimation for all drawing operations that use Paint with a mask filter blur (some users use mask filters to draw shadows instead of physica shapes or canvas.drawShadow).

Fixes flutter/flutter#32215

lib/web_ui/lib/src/engine/surface/scene_builder.dart

lib/web_ui/lib/src/engine/shadow.dart

cbracken · 2020-03-07T17:28:30Z

This appears to break golden file tests when rolling to the framework.

Roll: flutter/flutter#52165
Test failures: https://cirrus-ci.com/task/5681069831749632

cbracken · 2020-03-07T17:31:51Z

I'm going to revert this to get the roll through but when you're ready to re-land, we can deal with the golden file updates.

Broke golden file tests in the framework. Reverting to unblock the engine roll to the framework. This reverts commit 6cfa7fc.

cbracken · 2020-03-07T18:19:16Z

Revert landed and re-opened flutter/flutter#32215 until we re-land.

* 7c612de Roll fuchsia/sdk/core/linux-amd64 from cXgMr... to cTw2C... (flutter/engine#16970) * 6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963) * bfebadf Roll src/third_party/skia 012f8497802e..93a2a6b8badb (4 commits) (flutter/engine#16974) * 47963a5 Roll src/third_party/skia 93a2a6b8badb..74055566bd14 (2 commits) (flutter/engine#16981) * 98f9941 [fuchsia] fix broken flows when under high load (flutter/engine#16834) * fe051e0 Fix issue viewdidload call while init FlutterViewController (flutter/engine#16672) * 0ad54c2 [web] Fixes IE11 crash due to missing canvas ellipse support and font polyfill failure (flutter/engine#16965) * f6435de Roll fuchsia/sdk/core/mac-amd64 from J6ct_... to 95geB... (flutter/engine#16982) * 43971ca Roll src/third_party/skia 74055566bd14..54de2fa48d85 (3 commits) (flutter/engine#16983) * 45e61a6 Roll fuchsia/sdk/core/linux-amd64 from cTw2C... to K1wwe... (flutter/engine#16984) * 1ab5c36 Roll src/third_party/skia 54de2fa48d85..beaaf4700f50 (3 commits) (flutter/engine#16987) * e2c0454 remove 10s timeouts from tests (flutter/engine#16988) * dfc9c12 Roll src/third_party/skia beaaf4700f50..6e58290ba639 (9 commits) (flutter/engine#16990) * eddda80 fushia licenses fix (flutter/engine#16992) * c15f239 documented fluttertexture.h (flutter/engine#16950) * e1ba7a1 Roll src/third_party/skia 6e58290ba639..24a8e9e170f7 (5 commits) (flutter/engine#16996) * fc5963d [web] Engine integration test (flutter/engine#16930) * d323bac doxygen tooling updates and doxygen for FlutterCodecs.h (flutter/engine#16947) * 03ddc1d Started deleting .DS_Store files so licenses can run on mac os x. (flutter/engine#16998) * 30a8292 Roll src/third_party/skia 24a8e9e170f7..cf573d844da6 (4 commits) (flutter/engine#17004) * d031963 Roll fuchsia/sdk/core/mac-amd64 from 95geB... to hW33F... (flutter/engine#17006) * 41b371d Roll fuchsia/sdk/core/linux-amd64 from K1wwe... to FGMpI... (flutter/engine#17007) * 619acd5 Revert "fix shadows and mask filter blurs (#16963)" (flutter/engine#17008)

…lutter#17008)" This reverts commit 619acd5.

* fix shadows and mask filter blurs * update goldens * clarify the choice to min the shadows

…7008) Broke golden file tests in the framework. Reverting to unblock the engine roll to the framework. This reverts commit 6cfa7fc.

…#17040) This reverts 619acd5 and re-lands 6cfa7fc. The 6cfa7fc was good. The screenshot changes were expected. Fixes flutter/flutter#32215

fix shadows and mask filter blurs

5f50997

auto-assign bot requested a review from gw280 March 5, 2020 22:16

googlebot added the cla: yes label Mar 5, 2020

yjbanov added the Work in progress (WIP) Not ready (yet) for review! label Mar 5, 2020

update goldens

da44243

yjbanov requested a review from ferhatb March 5, 2020 23:07

ferhatb approved these changes Mar 6, 2020

View reviewed changes

lib/web_ui/lib/src/engine/surface/scene_builder.dart Show resolved Hide resolved

lib/web_ui/lib/src/engine/shadow.dart Show resolved Hide resolved

yjbanov removed the Work in progress (WIP) Not ready (yet) for review! label Mar 6, 2020

clarify the choice to min the shadows

4511731

yjbanov merged commit 6cfa7fc into flutter:master Mar 6, 2020

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 6, 2020

6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963)

19826ee

This was referenced Mar 6, 2020

Roll engine 5aff31194809..6cfa7fcad64e (2 commits) flutter/flutter#52089

Closed

Roll engine 5aff31194809..bfebadfce626 (3 commits) flutter/flutter#52103

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 6, 2020

6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963)

a277d76

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 6, 2020

6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963)

b2d135d

engine-flutter-autoroll mentioned this pull request Mar 6, 2020

Roll engine 5aff31194809..47963a598aef (4 commits) flutter/flutter#52123

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 6, 2020

6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963)

3ed8203

engine-flutter-autoroll mentioned this pull request Mar 6, 2020

Roll engine 5aff31194809..98f9941843da (5 commits) flutter/flutter#52129

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 6, 2020

6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963)

d05ec0b

engine-flutter-autoroll mentioned this pull request Mar 6, 2020

Roll engine 5aff31194809..0ad54c210659 (7 commits) flutter/flutter#52131

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 6, 2020

6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963)

cc5f167

engine-flutter-autoroll mentioned this pull request Mar 6, 2020

Roll engine 5aff31194809..f6435de88c7a (8 commits) flutter/flutter#52135

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 6, 2020

6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963)

b45beb6

engine-flutter-autoroll mentioned this pull request Mar 6, 2020

Roll engine 5aff31194809..43971caf04af (9 commits) flutter/flutter#52139

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 6, 2020

6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963)

197e31c

engine-flutter-autoroll mentioned this pull request Mar 6, 2020

Roll engine 5aff31194809..45e61a6ff777 (10 commits) flutter/flutter#52143

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 6, 2020

6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963)

fe29aa8

engine-flutter-autoroll mentioned this pull request Mar 6, 2020

Roll engine 5aff31194809..1ab5c3641caa (11 commits) flutter/flutter#52148

Closed

rydmike mentioned this pull request Mar 7, 2020

Shadows depend on internal canvas state flutter/flutter#51237

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2020

6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963)

c85d191

engine-flutter-autoroll mentioned this pull request Mar 7, 2020

Roll engine 5aff31194809..dfc9c126d0dd (13 commits) flutter/flutter#52153

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2020

6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963)

3f3e9bd

engine-flutter-autoroll mentioned this pull request Mar 7, 2020

Roll engine 5aff31194809..eddda803279c (14 commits) flutter/flutter#52154

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2020

6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963)

1f48a3f

engine-flutter-autoroll mentioned this pull request Mar 7, 2020

Roll engine 5aff31194809..c15f239c1e9e (15 commits) flutter/flutter#52155

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2020

6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963)

0637bb0

This was referenced Mar 7, 2020

Roll engine 5aff31194809..e1ba7a18f456 (16 commits) flutter/flutter#52156

Closed

Roll engine 5aff31194809..d323bace5f6f (18 commits) flutter/flutter#52159

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2020

6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963)

c03007a

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2020

6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963)

48129df

engine-flutter-autoroll mentioned this pull request Mar 7, 2020

Roll engine 5aff31194809..30a82927be82 (20 commits) flutter/flutter#52162

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2020

6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963)

fb7d079

This was referenced Mar 7, 2020

Roll engine 5aff31194809..d0319631bfb8 (21 commits) flutter/flutter#52164

Closed

Roll engine 5aff31194809..41b371d0b0be (22 commits) flutter/flutter#52165

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2020

6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963)

20f5817

cbracken added a commit to cbracken/flutter_engine that referenced this pull request Mar 7, 2020

Revert "fix shadows and mask filter blurs (flutter#16963)"

d4589e7

Broke golden file tests in the framework. Reverting to unblock the engine roll to the framework. This reverts commit 6cfa7fc.

cbracken added a commit that referenced this pull request Mar 7, 2020

Revert "fix shadows and mask filter blurs (#16963)" (#17008)

619acd5

Broke golden file tests in the framework. Reverting to unblock the engine roll to the framework. This reverts commit 6cfa7fc.

engine-flutter-autoroll mentioned this pull request Mar 7, 2020

Roll engine 5aff31194809..41b371d0b0be (22 commits) flutter/flutter#52176

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2020

6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963)

8fc44d6

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2020

6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963)

075162d

engine-flutter-autoroll mentioned this pull request Mar 7, 2020

Roll engine 5aff31194809..619acd58ca55 (23 commits) flutter/flutter#52177

Merged

yjbanov added a commit to yjbanov/engine that referenced this pull request Mar 9, 2020

Revert "Revert "fix shadows and mask filter blurs (flutter#16963)" (f…

45c64ac

…lutter#17008)" This reverts commit 619acd5.

blasten pushed a commit to blasten/engine that referenced this pull request Mar 10, 2020

fix shadows and mask filter blurs (flutter#16963)

02db05f

* fix shadows and mask filter blurs * update goldens * clarify the choice to min the shadows

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix shadows and mask filter blurs #16963

fix shadows and mask filter blurs #16963

Uh oh!

yjbanov commented Mar 5, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

cbracken commented Mar 7, 2020

Uh oh!

cbracken commented Mar 7, 2020

Uh oh!

cbracken commented Mar 7, 2020

Uh oh!

Uh oh!

fix shadows and mask filter blurs #16963

fix shadows and mask filter blurs #16963

Uh oh!

Conversation

yjbanov commented Mar 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cbracken commented Mar 7, 2020

Uh oh!

cbracken commented Mar 7, 2020

Uh oh!

cbracken commented Mar 7, 2020

Uh oh!

Uh oh!

yjbanov commented Mar 5, 2020 •

edited

Loading