This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Avoid creating separate system layers for PhysicalShapeLayers. #16975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change PhysicalShapeLayers to be composited by Flutter by default. In this case, shadows will be rendered too. If there is embedded Fuchsia content in the scene (a ChildSceneLayer), PhysicalShapeLayers that appear above the embedded content will be turned into their own Scenic layers. In this case, there will be no shadows rendered, as it is in the current implementation. We will change this later after clients adjust their usage of PSL once this change lands.
mikejurka
force-pushed
the
feb19_with_ps21
branch
from
e371c1b to
65b7c96
Compare
|
Two of us have done heavy manual testing, and the one issue turned out to be related to the texture format Scenic gets handed -- that's actually a bug that was uncovered and will be fixed in Escher/Scenic. So, no known bugs. Let us know what's the best way to get this reviewed. As with previous changes, this one could probably be split up into multiple (i think 3) if this is difficult to review. |
|
I created a new pull request which breaks this into smaller pieces: #17005 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change PhysicalShapeLayers to be composited by
Flutter by default. In this case, shadows will be
rendered too.
If there is embedded Fuchsia content in the scene
(a ChildSceneLayer), PhysicalShapeLayers that
appear above the embedded content will be turned
into their own Scenic layers.
In this case, there will be no shadows rendered, as
it is in the current implementation. We will change
this later after clients adjust their usage of PSL
once this change lands.