-
Notifications
You must be signed in to change notification settings - Fork 6k
Conversation
It would be nice to add a unit test that would fail if 2f971c8 isn't patched. |
Forgot to update the unit tests in the engine. On it... |
And, for the record, I also reran the framework golden tests for this widget with this local engine build and they passed. |
The existing unit tests that were landed in the original fix started failing when this was patched. I had to update them to reflect the new relationship between filtered and child bounds. So they are essentially asserting that the child and parent bounds meet the constraints now implemented. |
For added test coverage I updated the new Note that this created what looks like a strange diff because the tail end of the brand new |
Ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a nit.
The original fix in #16960 was passing the filtered bounds to the child savelayer which means 2 things:
when the filter grew the bounds, the child was painting into an unnecessarily large temporary surface before the filter grew the result again - which means a lot of transparent pixels would be in the source of the filter and the filter would have more useless work to do.
when the filter shrunk the bounds, the child was given a temporary surface that was too small to draw itself into and so the output was cropped.
Fixes flutter/flutter#51978