This repository was archived by the owner on Feb 25, 2025. It is now read-only.
reduce web shard count from 8 to 4 #17635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyuqian
reviewed
Apr 10, 2020
| << : *WEB_SHARD_TEMPLATE | ||
|
|
||
| - name: web_tests-7_last-linux # last Web shard must end with _last | ||
| - name: web_tests-3_last-linux # last Web shard must end with _last |
There was a problem hiding this comment.
The test failure seems to be still looking for web_tests-7_last-linux...
|
Looks like we can't reduce the shard count due to https://github.com/flutter/flutter/blob/2adb1fc095a009e0fc716a87d62fc31182ea74b4/dev/bots/test.dart#L48 |
|
@yjbanov : can we write a script to simply provide a fake |
|
@yjbanov : this PR probably needs to be rebased against newest master engine to pass the "Mac iOS Engine" test. |
yjbanov
force-pushed
the
reduce-web-shard-count
branch
from
dd9bb21 to
437efdf
Compare
|
Merging despite failing "Mac Android AOT Engine". Seems to be a flake. My changes are Web-only anyway. |
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
reduce web shard count from 8 to 4 by using WEB_SHARD_COUNT
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reportedly when we use too many shards we hit the Cirrus quota ceiling. Let's see if we can live with fewer shards.