This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Adjust the GLFW build options #17704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds an explicit option for not building the GLFW embedding. - Disables GLFW by default on Windows, where it's no longer the uploaded embedding. - Move the X11 pkg-config, which is only used by the GLFW embedding, behind the GLFW build flag.
| @@ -340,8 +339,10 @@ def parse_args(args): | |||
| help='The IDE files to generate using GN. Use `gn gen help` and look for the --ide flag to' + | |||
| ' see supported IDEs. If this flag is not specified, a platform specific default is selected.') | |||
|
|
|||
| parser.add_argument('--build-glfw-shell', dest='build_glfw_shell', default=False, action='store_true', | |||
| help='Force building the GLFW shell on desktop platforms where it is not built by default.') | |||
| parser.add_argument('--build-glfw-shell', action='store_const', const=True, | |||
There was a problem hiding this comment.
I thought argparse implicitly added a no- flag variant?
There was a problem hiding this comment.
I'm definitely not an argparse expert, but we're manually adding no- for stripped below already, and some quick searching turns up SO questions suggesting that it doesn't.
There was a problem hiding this comment.
I am not sure either, but if this pattern has been followed before, thats fine by me (I did not notice it in the initial review).
chinmaygarde
approved these changes
Apr 14, 2020
| @@ -340,8 +339,10 @@ def parse_args(args): | |||
| help='The IDE files to generate using GN. Use `gn gen help` and look for the --ide flag to' + | |||
| ' see supported IDEs. If this flag is not specified, a platform specific default is selected.') | |||
|
|
|||
| parser.add_argument('--build-glfw-shell', dest='build_glfw_shell', default=False, action='store_true', | |||
| help='Force building the GLFW shell on desktop platforms where it is not built by default.') | |||
| parser.add_argument('--build-glfw-shell', action='store_const', const=True, | |||
There was a problem hiding this comment.
I am not sure either, but if this pattern has been followed before, thats fine by me (I did not notice it in the initial review).
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 14, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 14, 2020
This was referenced Apr 14, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 14, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 15, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 15, 2020
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
- Adds an explicit option for not building the GLFW embedding. - Disables GLFW by default on Windows, where it's no longer the uploaded embedding. - Moves the X11 pkg-config, which is only used by the GLFW embedding, behind the GLFW build flag.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uploaded embedding.
behind the GLFW build flag.