This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Fix extra canvas generation due to context access #17710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Apr 14, 2020
| final ParagraphGeometricStyle style = paragraph._geometricStyle; | ||
|
|
||
| if (paragraph._drawOnCanvas && _childOverdraw == false) { | ||
| // !Do not move this assignment above this if clause since, accessing | ||
| // context will generate extra <canvas> tags. | ||
| html.CanvasRenderingContext2D ctx = _canvasPool.context; |
There was a problem hiding this comment.
You can move it even lower, into if (style != _cachedLastStyle), but not sure if it will make much difference.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 15, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 15, 2020
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
* Fix extra canvas generation due to context access * add comment * address review comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.