This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Added some tests after the fact for #17499 #17714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
approved these changes
Apr 14, 2020
| @@ -1,5 +1,7 @@ | |||
| #!/bin/sh | |||
|
|
|||
| set -e | |||
| SemanticsObject* parent = [[SemanticsObject alloc] initWithBridge:bridge uid:0]; | ||
| SemanticsObject* child = [[SemanticsObject alloc] initWithBridge:bridge uid:1]; | ||
| parent.children = @[child]; | ||
| XCTAssertEqual(parent, child.parent, @""); |
There was a problem hiding this comment.
You can leave off the @"" for all the XCAsserts, the message is optional.
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relevant pr: #17499