This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Release acquired typed data before calling Dart_SetReturnValue. #17729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we are going to hit an assertion in debug builds, as Dart API should not be used between Dart_TypedDataAcquireData and Dart_TypedDataReleaseData.
jason-simmons
approved these changes
Apr 15, 2020
jason-simmons
added
the
waiting for tree to go green
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we are going to hit an assertion in debug builds, as
Dart API should not be used between Dart_TypedDataAcquireData and
Dart_TypedDataReleaseData.
Fixes flutter/flutter#54433