This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add new FlutterEngineAOTData argument to FlutterProjectArgs #18146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For a real world example, here's the GLFW embedder updated to use the new API: https://github.com/MarcusTomlinson/glfw (see: README.md) |
MarcusTomlinson
changed the title
stuartmorgan-g
suggested changes
May 5, 2020
chinmaygarde
reviewed
May 5, 2020
|
Thanks for the reviews guys! Learnt a lot from them! |
|
@chinmaygarde, I just remembered, the additional |
stuartmorgan-g
approved these changes
May 7, 2020
chinmaygarde
approved these changes
May 7, 2020
|
@chinmaygarde, @stuartmorgan: I think that covers it :) Please could you merge when you get the chance. Thanks! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 11, 2020
wandyers
pushed a commit
to wandyers/engine
that referenced
this pull request
May 23, 2020
…18146) Added a new `FlutterEngineAOTData` argument to `FlutterProjectArgs`. Embedders can instantiate and destroy this object via the new `FlutterEngineCreateAOTData` and `FlutterEngineCollectAOTData` methods provided. If an embedder provides more than one source of AOT data to `FlutterEngineInitialize` or `FlutterEngineRun` (e.g. snapshots as well as `FlutterEngineAOTData`), the engine will error out. Resolves: flutter/flutter#50778
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new
FlutterEngineAOTDataargument toFlutterProjectArgs. Embedders can instantiate and destroy this object via the newFlutterEngineCreateAOTDataandFlutterEngineCollectAOTDatamethods provided.If an embedder provides more than one source of AOT data to
FlutterEngineInitializeorFlutterEngineRun(e.g. snapshots as well asFlutterEngineAOTData), the engine will error out.Resolves: flutter/flutter#50778