Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Fix arc rendering when it starts a new sub path. #18535

Merged
merged 3 commits into from
May 20, 2020
Merged

[web] Fix arc rendering when it starts a new sub path. #18535

merged 3 commits into from
May 20, 2020

Conversation

ferhatb
Copy link
Contributor

@ferhatb ferhatb commented May 20, 2020

Related issue: flutter/flutter#57214

@ferhatb ferhatb requested a review from mdebbar May 20, 2020 19:49
@ferhatb ferhatb requested a review from ditman May 20, 2020 19:50
@ditman
Copy link
Member

ditman commented May 20, 2020

Golden PR: flutter/goldens#98

ditman
ditman approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you trigger another CI build after the Golden has been merged, so test here don't fail?

mdebbar
mdebbar approved these changes May 20, 2020
View reviewed changes
lib/web_ui/lib/src/engine/canvas_pool.dart
Comment on lines +523 to +527
if (c == 0) {
// Ellipses that start a new path need to set start point,
// otherwise it incorrectly uses last point.
ctx.moveTo(subpath.startX, subpath.startY);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not the case for other path command types?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, all other commands assume you are already at some point, and they draw from there.

@ferhatb ferhatb merged commit 7f69f0d into flutter:master May 20, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2020
@engine-flutter-autoroll
7f69f0d [web] Fix arc rendering when it starts a new sub path. (flutt…
946ebb4 
…er/engine#18535)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2020
@engine-flutter-autoroll
7f69f0d [web] Fix arc rendering when it starts a new sub path. (flutt…
7d1d3c8 
…er/engine#18535)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020
@engine-flutter-autoroll
7f69f0d [web] Fix arc rendering when it starts a new sub path. (flutt…
e368dfa 
…er/engine#18535)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020
@engine-flutter-autoroll
7f69f0d [web] Fix arc rendering when it starts a new sub path. (flutt…
9ed45c0 
…er/engine#18535)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020
@engine-flutter-autoroll
7f69f0d [web] Fix arc rendering when it starts a new sub path. (flutt…
b89da23 
…er/engine#18535)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020
@engine-flutter-autoroll
7f69f0d [web] Fix arc rendering when it starts a new sub path. (flutt…
0728bb5 
…er/engine#18535)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020
@engine-flutter-autoroll
7f69f0d [web] Fix arc rendering when it starts a new sub path. (flutt…
00f17c6 
…er/engine#18535)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 22, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 22, 2020
@engine-flutter-autoroll
7f69f0d [web] Fix arc rendering when it starts a new sub path. (flutt…
4b0a268 
…er/engine#18535)
wandyers pushed a commit to wandyers/engine that referenced this pull request May 23, 2020
@ferhatb @wandyers
[web] Fix arc rendering when it starts a new sub path. (flutter#18535)
3f16915 
* Fix Path.addArc failure due to incorrect start position
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 23, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2020
@engine-flutter-autoroll
7f69f0d [web] Fix arc rendering when it starts a new sub path. (flutt…
a401bab 
…er/engine#18535)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 26, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 26, 2020
@engine-flutter-autoroll
7f69f0d [web] Fix arc rendering when it starts a new sub path. (flutt…
c4d3628 
…er/engine#18535)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 26, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 26, 2020
@engine-flutter-autoroll
7f69f0d [web] Fix arc rendering when it starts a new sub path. (flutt…
c49356c 
…er/engine#18535)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 26, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 26, 2020
@engine-flutter-autoroll
7f69f0d [web] Fix arc rendering when it starts a new sub path. (flutt…
6fbcc22 
…er/engine#18535)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 26, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 26, 2020
@engine-flutter-autoroll
7f69f0d [web] Fix arc rendering when it starts a new sub path. (flutt…
709a681 
…er/engine#18535)
liyuqian added a commit to liyuqian/flutter that referenced this pull request May 26, 2020
@liyuqian
Roll Engine from 9ce1e5c to 1a83498 (69 revisions)
0516672 
Roll Engine from 9ce1e5c to 1a83498 (69 revisions)

flutter/engine@9ce1e5c...1a83498

2020-05-26 [email protected] Revert "Update CanvasKit to 0.15.0 (flutter#18570)" (flutter/engine#18600)
2020-05-26 [email protected] Roll Fuchsia Mac SDK from TSEOq... to hr-HZ... (flutter/engine#18594)
2020-05-26 [email protected] Roll Dart SDK from 65113fd73dec to 9e3b0289197d (2 revisions) (flutter/engine#18593)
2020-05-26 [email protected] Roll Skia from b6d158aaf3dd to e4b4ca1050b9 (1 revision) (flutter/engine#18592)
2020-05-26 [email protected] Roll Fuchsia Linux SDK from DzG49... to pLp67... (flutter/engine#18591)
2020-05-24 [email protected] Roll Fuchsia Mac SDK from Oz016... to TSEOq... (flutter/engine#18590)
2020-05-23 [email protected] Roll Skia from afd8a6c6ae87 to b6d158aaf3dd (3 revisions) (flutter/engine#18588)
2020-05-22 [email protected] Roll Fuchsia Mac SDK from 99Z4_... to Oz016... (flutter/engine#18582)
2020-05-22 [email protected] Roll Skia from ec31488ace66 to afd8a6c6ae87 (1 revision) (flutter/engine#18581)
2020-05-22 [email protected] Roll Fuchsia Linux SDK from Kvwlr... to DzG49... (flutter/engine#18580)
2020-05-22 [email protected] Roll Skia from 80abb89c3632 to ec31488ace66 (1 revision) (flutter/engine#18579)
2020-05-22 [email protected] Roll Skia from da90c3765908 to 80abb89c3632 (4 revisions) (flutter/engine#18577)
2020-05-22 [email protected] Roll Fuchsia Mac SDK from _zNmv... to 99Z4_... (flutter/engine#18576)
2020-05-22 [email protected] Roll Skia from 317dce5c81c0 to da90c3765908 (1 revision) (flutter/engine#18575)
2020-05-22 [email protected] Roll Dart SDK from 4ee57c08e0a6 to 65113fd73dec (3 revisions) (flutter/engine#18574)
2020-05-22 [email protected] Roll Skia from 67e21a19259b to 317dce5c81c0 (3 revisions) (flutter/engine#18573)
2020-05-22 [email protected] Update CanvasKit to 0.15.0 (flutter/engine#18570)
2020-05-21 [email protected] Roll Skia from 3d52abc84667 to 67e21a19259b (1 revision) (flutter/engine#18568)
2020-05-21 [email protected] Roll Dart SDK from 396b5fb7a97d to 4ee57c08e0a6 (6 revisions) (flutter/engine#18567)
2020-05-21 [email protected] Add fl_value_to_string (flutter/engine#18540)
2020-05-21 [email protected] Roll Skia from 1e63279156d6 to 3d52abc84667 (5 revisions) (flutter/engine#18566)
2020-05-21 [email protected] null-annotate semantics.dart (flutter/engine#18553)
2020-05-21 [email protected] Roll Fuchsia Linux SDK from ciqRH... to Kvwlr... (flutter/engine#18565)
2020-05-21 [email protected] Roll Skia from b37105ea6cca to 1e63279156d6 (9 revisions) (flutter/engine#18564)
2020-05-21 [email protected] Implement WriteAtomically using write/fsync on all platforms, and enable (flutter/engine#18320)
2020-05-21 [email protected] Roll Dart SDK from ecce58c1e354 to 396b5fb7a97d (2 revisions) (flutter/engine#18560)
2020-05-21 [email protected] Roll Fuchsia Mac SDK from RNByJ... to _zNmv... (flutter/engine#18558)
2020-05-21 [email protected] [profiling] Memory Profiling support for iOS (flutter/engine#18516)
2020-05-21 [email protected] Roll Skia from 22636205ce92 to b37105ea6cca (2 revisions) (flutter/engine#18557)
2020-05-21 [email protected] Roll Dart SDK from d551980ac9fc to ecce58c1e354 (2 revisions) (flutter/engine#18556)
2020-05-21 [email protected] Roll Dart SDK from bf7e9d13d730 to d551980ac9fc (6 revisions) (flutter/engine#18551)
2020-05-21 [email protected] Roll Skia from 4c0578632217 to 22636205ce92 (4 revisions) (flutter/engine#18550)
2020-05-21 [email protected] Roll Fuchsia Linux SDK from ThMeW... to ciqRH... (flutter/engine#18549)
2020-05-21 [email protected] Roll Skia from 67ff541ac116 to 4c0578632217 (1 revision) (flutter/engine#18547)
2020-05-21 [email protected] Let run_tests.py just stream output (flutter/engine#18534)
2020-05-21 [email protected] Add FlKeyEventPlugin (flutter/engine#18313)
2020-05-21 [email protected] Add tests for StandardMethodCodec (flutter/engine#18521)
2020-05-21 [email protected] Roll Skia from f83baf230c69 to 67ff541ac116 (1 revision) (flutter/engine#18545)
2020-05-21 [email protected] Roll Fuchsia Mac SDK from 3o9aQ... to RNByJ... (flutter/engine#18543)
2020-05-21 [email protected] fuchsia: Fix runtime_tests and shell_tests (flutter/engine#18492)
2020-05-21 [email protected] Roll Skia from d2dc8ddcdf5e to f83baf230c69 (2 revisions) (flutter/engine#18539)
2020-05-21 [email protected] Roll Dart SDK from 7aa8656d1dd8 to bf7e9d13d730 (21 revisions) (flutter/engine#18538)
2020-05-21 [email protected] Add FlMethodChannel, FlMethodCodec, FlStandardMethodCodec and FlJsonMethodCodec (flutter/engine#18220)
2020-05-20 [email protected] [web] Fix arc rendering when it starts a new sub path. (flutter/engine#18535)
2020-05-20 [email protected] Send platformResolvedLocale from iOS embedder (flutter/engine#18519)
2020-05-20 [email protected] System mouse cursor: macOS (flutter/engine#18131)
...
@liyuqian liyuqian mentioned this pull request May 26, 2020
Closed
@ferhatb ferhatb deleted the addarc branch August 10, 2020 20:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mdebbar mdebbar mdebbar approved these changes

@ditman ditman ditman approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ferhatb @ditman @mdebbar @googlebot