This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fuchsia: Remove dead code / break dependencies #19396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbreng
force-pushed
the
fuchsia-dead-code
branch
3 times, most recently
from
a08314f to
3b25c43
Compare
gw280
approved these changes
Jun 30, 2020
There was a problem hiding this comment.
LGTM but I'm not an expert on the layers code. I'd like @chinmaygarde or someone else to also LGTM this before it's merged.
arbreng
force-pushed
the
fuchsia-dead-code
branch
2 times, most recently
from
502d833 to
3587761
Compare
chinmaygarde
approved these changes
Jun 30, 2020
arbreng
force-pushed
the
fuchsia-dead-code
branch
2 times, most recently
from
7cf66c1 to
6fa5c32
Compare
arbreng
force-pushed
the
fuchsia-dead-code
branch
from
6fa5c32 to
1e8c3c1
Compare
arbreng
force-pushed
the
fuchsia-dead-code
branch
2 times, most recently
from
7e2b52d to
2348802
Compare
arbreng
force-pushed
the
fuchsia-dead-code
branch
3 times, most recently
from
6105238 to
8e0750d
Compare
|
@arbreng Can we land or close this? |
arbreng
force-pushed
the
fuchsia-dead-code
branch
from
8e0750d to
7134e10
Compare
Yep, trying to do so today :) There were several internal tests failing on this CL, so I wanted to make sure they worked first. Now to get it past Flutter's CI.. |
arbreng
force-pushed
the
fuchsia-dead-code
branch
from
a9d6cc0 to
8717760
Compare
arbreng
force-pushed
the
fuchsia-dead-code
branch
from
8717760 to
aaa1e00
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 4, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 4, 2020
zanderso
added a commit
that referenced
this pull request
Aug 6, 2020
renyou
pushed a commit
to renyou/engine
that referenced
this pull request
Aug 7, 2020
…" (flutter#20302) This reverts commit 12a3747.
renyou
added a commit
that referenced
this pull request
Aug 7, 2020
) (#20327) This reverts commit 12a3747. Co-authored-by: Zachary Anderson <[email protected]>
arbreng
added a commit
that referenced
this pull request
Aug 15, 2020
Reland #19396 with a fix for improper scale that was affecting internal tests Tested: Ran all unittests, ran internal tests, and ran workstation on Fuchsia BUG: 53062, 53063
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fuchsia code around metrics and sizing was just sending this
information through a side-channel, when the engine already had the
information available. So, delete all of it to make future CLs simpler.
Additionally, the SceneUpdateContext has many unneccesary dependencies
re: metrics and PaintTasks. Break those to make future CLs simpler.
Tested: Ran all unittests and ran workstation on Fuchsia
BUG: 53062, 53063